Allow PushToBuildStorage to only push the asset manifest (#15639)

Author: jkoritzinsky

Diff for: src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj

@@ -87,6 +87,7 @@
       ('$(DotNetBuildSourceOnly)' != 'true' or ('$(DotNetBuildInnerRepo)' == 'true' and '$(DotNetBuildOrchestrator)' != 'true'))">true</AutoGenerateSymbolPackages>
 
     <PreserveRepoOrigin Condition="'$(PreserveRepoOrigin)' == ''">false</PreserveRepoOrigin>
+    <PublishManifestOnly Condition="'$(PublishManifestOnly)' == ''">false</PublishManifestOnly>
 
     <!-- This tracks the dependent targets of PublishToAzureDevOpsArtifacts. We can't rename this
          property as it is used by other repositories already. -->
@@ -373,7 +374,8 @@
       AssetManifestsLocalStorageDir="$(SourceBuiltAssetManifestsDir)"
       PdbArtifactsLocalStorageDir="$(PdbArtifactsSourceBuiltOrTempDir)"
       ArtifactVisibilitiesToPublish="@(ArtifactVisibilityToPublish)"
-      UseHardlinksIfPossible="$(PublishingUseHardlinksIfPossible)" />
+      UseHardlinksIfPossible="$(PublishingUseHardlinksIfPossible)"
+      PublishManifestOnly="$(PublishManifestOnly)" />
   </Target>
 
   <!-- Import the publish targets when in the inner or outer repo builds. -->

Diff for: src/Microsoft.DotNet.Build.Tasks.Feed.Tests/GenerateBuildManifestTests.cs

@@ -102,6 +102,9 @@ public class PushToBuildStorage : MSBuildTaskBase
         /// </summary>
         public bool PreserveRepoOrigin { get; set; }
 
+        /// <summary>
+        /// The visibility of the artifacts to put in the manifest.
+        /// </summary>
         public ITaskItem[] ArtifactVisibilitiesToPublish { get; set; }
 
         /// <summary>
@@ -116,6 +119,8 @@ public class PushToBuildStorage : MSBuildTaskBase
         /// </summary>
         public bool UseHardlinksIfPossible { get; set; } = true;
 
+        public bool PublishManifestOnly { get; set; } = false;
+
         public override void ConfigureServices(IServiceCollection collection)
         {
             collection.TryAddSingleton<IBlobArtifactModelFactory, BlobArtifactModelFactory>();
@@ -138,12 +143,19 @@ public bool ExecuteTask(IFileSystem fileSystem,
             {
                 if (PushToLocalStorage)
                 {
-                    if (string.IsNullOrEmpty(AssetsLocalStorageDir) ||
-                        string.IsNullOrEmpty(ShippingPackagesLocalStorageDir) ||
-                        string.IsNullOrEmpty(NonShippingPackagesLocalStorageDir) ||
-                        string.IsNullOrEmpty(AssetManifestsLocalStorageDir))
+                    if (!PublishManifestOnly)
+                    {
+                        if (string.IsNullOrEmpty(AssetsLocalStorageDir) ||
+                            string.IsNullOrEmpty(ShippingPackagesLocalStorageDir) ||
+                            string.IsNullOrEmpty(NonShippingPackagesLocalStorageDir) ||
+                            string.IsNullOrEmpty(PdbArtifactsLocalStorageDir))
+                        {
+                            throw new Exception($"AssetsLocalStorageDir, ShippingPackagesLocalStorageDir, NonShippingPackagesLocalStorageDir and PdbArtifactsLocalStorageDir need to be specified if PublishToLocalStorage is set to true");
+                        }
+                    }
+                    if (string.IsNullOrEmpty(AssetManifestsLocalStorageDir))
                     {
-                        throw new Exception($"AssetsLocalStorageDir, ShippingPackagesLocalStorageDir, NonShippingPackagesLocalStorageDir and AssetManifestsLocalStorageDir need to be specified if PublishToLocalStorage is set to true");
+                        throw new Exception($"AssetManifestsLocalStorageDir needs to be specified if PublishToLocalStorage is set to true");
                     }
 
                     Log.LogMessage(MessageImportance.High, "Performing push to local artifacts storage.");
@@ -195,43 +207,46 @@ public bool ExecuteTask(IFileSystem fileSystem,
                         throw new Exception($"PdbArtifactsLocalStorageDir must be specified.");
                     }
 
-                    foreach (var package in buildModel.Artifacts.Packages)
+                    if (!PublishManifestOnly)
                     {
-                        if (!fileSystem.FileExists(package.OriginalFile))
+                        foreach (var package in buildModel.Artifacts.Packages)
                         {
-                            Log.LogError($"Could not find file {package.OriginalFile}.");
-                            continue;
-                        }
+                            if (!fileSystem.FileExists(package.OriginalFile))
+                            {
+                                Log.LogError($"Could not find file {package.OriginalFile}.");
+                                continue;
+                            }
 
-                        PushToLocalStorageOrAzDO(package);
-                    }
+                            PushToLocalStorageOrAzDO(package);
+                        }
 
-                    foreach (var blobArtifact in buildModel.Artifacts.Blobs)
-                    {
-                        if (!fileSystem.FileExists(blobArtifact.OriginalFile))
+                        foreach (var blobArtifact in buildModel.Artifacts.Blobs)
                         {
-                            Log.LogError($"Could not find file {blobArtifact.OriginalFile}.");
-                            continue;
-                        }
+                            if (!fileSystem.FileExists(blobArtifact.OriginalFile))
+                            {
+                                Log.LogError($"Could not find file {blobArtifact.OriginalFile}.");
+                                continue;
+                            }
 
-                        PushToLocalStorageOrAzDO(blobArtifact);
-                    }
+                            PushToLocalStorageOrAzDO(blobArtifact);
+                        }
 
-                    foreach (var pdbArtifact in buildModel.Artifacts.Pdbs)
-                    {
-                        if (!fileSystem.FileExists(pdbArtifact.OriginalFile))
+                        foreach (var pdbArtifact in buildModel.Artifacts.Pdbs)
                         {
-                            Log.LogError($"Could not find file {pdbArtifact.OriginalFile}.");
-                            continue;
+                            if (!fileSystem.FileExists(pdbArtifact.OriginalFile))
+                            {
+                                Log.LogError($"Could not find file {pdbArtifact.OriginalFile}.");
+                                continue;
+                            }
+                            PushToLocalStorageOrAzDO(pdbArtifact);
                         }
-                        PushToLocalStorageOrAzDO(pdbArtifact);
-                    }
 
-                    if (!PushToLocalStorage && buildModel.Artifacts.Pdbs.Any())
-                    {
-                        // Upload the full set of PDBs
-                        Log.LogMessage(MessageImportance.High,
-                            $"##vso[artifact.upload containerfolder=PdbArtifacts;artifactname=PdbArtifacts]{PdbArtifactsLocalStorageDir}");
+                        if (!PushToLocalStorage && buildModel.Artifacts.Pdbs.Any())
+                        {
+                            // Upload the full set of PDBs
+                            Log.LogMessage(MessageImportance.High,
+                                $"##vso[artifact.upload containerfolder=PdbArtifacts;artifactname=PdbArtifacts]{PdbArtifactsLocalStorageDir}");
+                        }
                     }
 
                     // Write the manifest, then create an artifact for it.