You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DotNetPublishUsingPIpelines unintentionally meant "publishing or not". DotNetPublishUsingPipelines should never have been used to differentiate actually publishing vs. not. It was only used to differentiate two types of publishing, and it was originally supposed to be removed when we moved from V2 publishing to V3. This has been lurking for a LONG time.
Not all repos hit this:
Lots of repos deal with publishing in different ways:
They only build things that should publish in their official builds - I think this is the case for most repos.
They don't use cibuild.cmd, and do not pass --publish in their official build for legs that should not publish.
Proposed Solutions:
Remove -publish from cibuild.cmd/sh - Pass explicitly where necessary.
Change repos that build a surplus in their official builds to use eng/common/build.sh/cmd and only pass -publish in the legs that should publish
Preferred Solution:
I favor the first option if cibuild.cmd is sparingly used through the .NET ecosystem. We can fix up the few cases that use it. I favor the second if cibuild.cmd is used in lots of places, but where most repos are only building what they need want to ship in their official builds.
Need to first investigate what repos are doing.
The text was updated successfully, but these errors were encountered:
DotNetPublishUsingPIpelines unintentionally meant "publishing or not". DotNetPublishUsingPipelines should never have been used to differentiate actually publishing vs. not. It was only used to differentiate two types of publishing, and it was originally supposed to be removed when we moved from V2 publishing to V3. This has been lurking for a LONG time.
Not all repos hit this:
Lots of repos deal with publishing in different ways:
Proposed Solutions:
Preferred Solution:
I favor the first option if cibuild.cmd is sparingly used through the .NET ecosystem. We can fix up the few cases that use it. I favor the second if cibuild.cmd is used in lots of places, but where most repos are only building what they need want to ship in their official builds.
Need to first investigate what repos are doing.
The text was updated successfully, but these errors were encountered: