Skip to content

DotNetPublishUsingPipelines removal caused some repos to start publishing -ci packages #15641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmitche opened this issue Mar 14, 2025 · 0 comments

Comments

@mmitche
Copy link
Member

mmitche commented Mar 14, 2025

DotNetPublishUsingPIpelines unintentionally meant "publishing or not". DotNetPublishUsingPipelines should never have been used to differentiate actually publishing vs. not. It was only used to differentiate two types of publishing, and it was originally supposed to be removed when we moved from V2 publishing to V3. This has been lurking for a LONG time.

Not all repos hit this:

Lots of repos deal with publishing in different ways:

  • They only build things that should publish in their official builds - I think this is the case for most repos.
  • They don't use cibuild.cmd, and do not pass --publish in their official build for legs that should not publish.

Proposed Solutions:

  • Remove -publish from cibuild.cmd/sh - Pass explicitly where necessary.
  • Change repos that build a surplus in their official builds to use eng/common/build.sh/cmd and only pass -publish in the legs that should publish

Preferred Solution:

I favor the first option if cibuild.cmd is sparingly used through the .NET ecosystem. We can fix up the few cases that use it. I favor the second if cibuild.cmd is used in lots of places, but where most repos are only building what they need want to ship in their official builds.

Need to first investigate what repos are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant