Skip to content

Commit 5aa72df

Browse files
committed
Fix build break
1 parent 3d6868e commit 5aa72df

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

Diff for: test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsInfrastructureSqlServerTest.cs

+10-6
Original file line numberDiff line numberDiff line change
@@ -985,9 +985,11 @@ public void Non_transactional_migration_is_retried()
985985
{
986986
using var context = new BloggingContext(
987987
Fixture.TestStore.AddProviderOptions(
988-
new DbContextOptionsBuilder().EnableServiceProviderCaching(false))
989-
.ConfigureWarnings(e => e.Log(RelationalEventId.PendingModelChangesWarning))
990-
.UseLoggerFactory(Fixture.TestSqlLoggerFactory).Options);
988+
new DbContextOptionsBuilder().EnableServiceProviderCaching(false))
989+
.ConfigureWarnings(
990+
e => e.Log(
991+
RelationalEventId.PendingModelChangesWarning, RelationalEventId.NonTransactionalMigrationOperationWarning))
992+
.UseLoggerFactory(Fixture.TestSqlLoggerFactory).Options);
991993

992994
context.Database.EnsureDeleted();
993995
GiveMeSomeTime(context);
@@ -1078,9 +1080,11 @@ public async Task Non_transactional_migration_is_retried_async()
10781080
{
10791081
using var context = new BloggingContext(
10801082
Fixture.TestStore.AddProviderOptions(
1081-
new DbContextOptionsBuilder().EnableServiceProviderCaching(false))
1082-
.ConfigureWarnings(e => e.Log(RelationalEventId.PendingModelChangesWarning))
1083-
.UseLoggerFactory(Fixture.TestSqlLoggerFactory).Options);
1083+
new DbContextOptionsBuilder().EnableServiceProviderCaching(false))
1084+
.ConfigureWarnings(
1085+
e => e.Log(
1086+
RelationalEventId.PendingModelChangesWarning, RelationalEventId.NonTransactionalMigrationOperationWarning))
1087+
.UseLoggerFactory(Fixture.TestSqlLoggerFactory).Options);
10841088

10851089
context.Database.EnsureDeleted();
10861090
GiveMeSomeTime(context);

Diff for: test/EFCore.SqlServer.FunctionalTests/SqlServerDatabaseCreatorTest.cs

+7-4
Original file line numberDiff line numberDiff line change
@@ -532,10 +532,13 @@ public async Task Throws_if_database_does_not_exist(bool async)
532532
using var testDatabase = SqlServerTestStore.GetOrCreate("NonExisting");
533533
var creator = GetDatabaseCreator(testDatabase);
534534

535-
var errorNumber
536-
= async
537-
? (await Assert.ThrowsAsync<SqlException>(() => creator.CreateTablesAsync())).Number
538-
: Assert.Throws<SqlException>(() => creator.CreateTables()).Number;
535+
var exception = async
536+
? (await Assert.ThrowsAsync<RetryLimitExceededException>(() => creator.CreateTablesAsync()))
537+
: Assert.Throws<RetryLimitExceededException>(() => creator.CreateTables());
538+
539+
Assert.Equal(CoreStrings.RetryLimitExceeded(6, "TestSqlServerRetryingExecutionStrategy"), exception.Message);
540+
541+
var errorNumber = ((SqlException)exception.InnerException!).Number;
539542

540543
if (errorNumber != 233) // skip if no-process transient failure
541544
{

0 commit comments

Comments
 (0)