Round of feedback.

Author: cincuranet

Diff for: src/EFCore.Relational/Diagnostics/CommandEndEventData.cs

@@ -19,7 +19,7 @@ public class CommandEndEventData : CommandEventData
     /// <param name="messageGenerator">A delegate that generates a log message for this event.</param>
     /// <param name="connection">The <see cref="DbConnection" /> being used.</param>
     /// <param name="command">The <see cref="DbCommand" />.</param>
-    /// <param name="logCommandText">The command text that can be logged in case <see cref="DbCommand.CommandText" /> contains sensitive information.</param>
+    /// <param name="logCommandText">The command text that can be logged.</param>
     /// <param name="context">The <see cref="DbContext" /> currently being used, to null if not known.</param>
     /// <param name="executeMethod">The <see cref="DbCommand" /> method.</param>
     /// <param name="commandId">A correlation ID that identifies the <see cref="DbCommand" /> instance being used.</param>
@@ -34,7 +34,7 @@ public CommandEndEventData(
         Func<EventDefinitionBase, EventData, string> messageGenerator,
         DbConnection connection,
         DbCommand command,
-        string? logCommandText,
+        string logCommandText,
         DbContext? context,
         DbCommandMethod executeMethod,
         Guid commandId,

Diff for: src/EFCore.Relational/Diagnostics/CommandErrorEventData.cs

@@ -18,7 +18,7 @@ public class CommandErrorEventData : CommandEndEventData, IErrorEventData
     /// <param name="messageGenerator">A delegate that generates a log message for this event.</param>
     /// <param name="connection">The <see cref="DbConnection" /> being used.</param>
     /// <param name="command">The <see cref="DbCommand" /> that was executing when it failed.</param>
-    /// <param name="logCommandText">The command text that can be logged in case <see cref="DbCommand.CommandText" /> contains sensitive information.</param>
+    /// <param name="logCommandText">The command text that can be logged.</param>
     /// <param name="context">The <see cref="DbContext" /> currently being used, to null if not known.</param>
     /// <param name="executeMethod">The <see cref="DbCommand" /> method that was used to execute the command.</param>
     /// <param name="commandId">A correlation ID that identifies the <see cref="DbCommand" /> instance being used.</param>
@@ -34,7 +34,7 @@ public CommandErrorEventData(
         Func<EventDefinitionBase, EventData, string> messageGenerator,
         DbConnection connection,
         DbCommand command,
-        string? logCommandText,
+        string logCommandText,
         DbContext? context,
         DbCommandMethod executeMethod,
         Guid commandId,

Diff for: src/EFCore.Relational/Diagnostics/CommandEventData.cs

@@ -25,21 +25,21 @@ public class CommandEventData : CommandCorrelatedEventData
     /// <param name="commandId">A correlation ID that identifies the <see cref="DbCommand" /> instance being used.</param>
     /// <param name="connectionId">A correlation ID that identifies the <see cref="DbConnection" /> instance being used.</param>
     /// <param name="async">Indicates whether or not the command was executed asynchronously.</param>
-    /// <param name="logSensitiveValues">Indicates whether or not the application allows logging of sensitive values.</param>
+    /// <param name="logParameterValues">Indicates whether or not the application allows logging of parameter values.</param>
     /// <param name="startTime">The start time of this event.</param>
     /// <param name="commandSource">Source of the command.</param>
     public CommandEventData(
         EventDefinitionBase eventDefinition,
         Func<EventDefinitionBase, EventData, string> messageGenerator,
         DbConnection connection,
         DbCommand command,
-        string? logCommandText,
+        string logCommandText,
         DbContext? context,
         DbCommandMethod executeMethod,
         Guid commandId,
         Guid connectionId,
         bool async,
-        bool logSensitiveValues,
+        bool logParameterValues,
         DateTimeOffset startTime,
         CommandSource commandSource)
         : base(
@@ -56,7 +56,7 @@ public CommandEventData(
     {
         Command = command;
         LogCommandText = logCommandText;
-        LogSensitiveValues = logSensitiveValues;
+        LogParameterValues = logParameterValues;
     }
 
     /// <summary>
@@ -67,10 +67,10 @@ public CommandEventData(
     /// <summary>
     ///     The command text that can be logged in case <see cref="DbCommand.CommandText" /> contains sensitive information.
     /// </summary>
-    public virtual string? LogCommandText { get; }
+    public virtual string LogCommandText { get; }
 
     /// <summary>
     ///     Indicates whether or not the application allows logging of parameter values.
     /// </summary>
-    public virtual bool LogSensitiveValues { get; }
+    public virtual bool LogParameterValues { get; }
 }

Diff for: src/EFCore.Relational/Diagnostics/CommandExecutedEventData.cs

@@ -18,7 +18,7 @@ public class CommandExecutedEventData : CommandEndEventData
     /// <param name="messageGenerator">A delegate that generates a log message for this event.</param>
     /// <param name="connection">The <see cref="DbConnection" /> being used.</param>
     /// <param name="command">The <see cref="DbCommand" /> that was executing when it failed.</param>
-    /// <param name="logCommandText">The command text that can be logged in case <see cref="DbCommand.CommandText" /> contains sensitive information.</param>
+    /// <param name="logCommandText">The command text that can be logged.</param>
     /// <param name="context">The <see cref="DbContext" /> currently being used, to null if not known.</param>
     /// <param name="executeMethod">The <see cref="DbCommand" /> method that was used to execute the command.</param>
     /// <param name="commandId">A correlation ID that identifies the <see cref="DbCommand" /> instance being used.</param>
@@ -34,7 +34,7 @@ public CommandExecutedEventData(
         Func<EventDefinitionBase, EventData, string> messageGenerator,
         DbConnection connection,
         DbCommand command,
-        string? logCommandText,
+        string logCommandText,
         DbContext? context,
         DbCommandMethod executeMethod,
         Guid commandId,