Skip to content

Redact inlined constants from log when sensitive logging is off #35757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cincuranet opened this issue Mar 10, 2025 · 1 comment · Fixed by #35724
Closed

Redact inlined constants from log when sensitive logging is off #35757

cincuranet opened this issue Mar 10, 2025 · 1 comment · Fixed by #35724
Assignees
@cincuranet
Labels
area-logging area-query preview-3 type-enhancement
Milestone
10.0.0

Comments

@cincuranet
Copy link
Contributor

In certain scenarios we inline - create constant directly in query - what was originally a parameter. If it would be a parameter and sensitive logging would be off, the value in log will be redacted. We should do the same for these inlined constants.
@cincuranet cincuranet added this to the 10.0.0 milestone Mar 10, 2025
@cincuranet cincuranet self-assigned this Mar 10, 2025
@cincuranet cincuranet mentioned this issue Mar 10, 2025
Merged
@stevendarby
Copy link
Contributor

Duplicate?

#24539

@roji roji marked this as a duplicate of #24539 Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cincuranet cincuranet

Labels
area-logging area-query preview-3 type-enhancement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Redact constants that get inlined from variables into query in log cincuranet/efcore
4 participants
@maumar @roji @cincuranet @stevendarby