Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prebuilt baseline failures on Windows CI #907

Closed
dagood opened this issue Nov 20, 2018 · 2 comments
Closed

Enable prebuilt baseline failures on Windows CI #907

dagood opened this issue Nov 20, 2018 · 2 comments

Comments

@dagood
Copy link
Member

dagood commented Nov 20, 2018

In #898, Windows CI was enabled in 2.1, but it ignores prebuilt baseline failures. It makes sense that Windows is different enough that it pulls in different prebuilts.

I'm not aware of any scenario where prebuilts for the Windows build matter, but filing this to track.

(Prebuilt baseline failure might happen to detect when we use a prebuilt package rather than a source-built package, but cache conflict detection catches this situation in a much more targeted way. It would have a lot more value to fix what it detects regularly (even baseline it?) and change that into an error.)

@dagood
Copy link
Member Author

dagood commented Nov 29, 2018

A situation this can catch is if a submodule builds the wrong packages and downstream repos pull in prebuilts instead. Wrong packages can be built e.g. if the portable build passing code breaks due to a submodule update: CoreCLR builds portable, then Core-Setup builds non-portable and tries to find non-portable CoreCLR bits.

We have a separate sanity check to detect when no packages are built, but it doesn't catch wrong packages.

@crummel
Copy link
Contributor

crummel commented Jul 11, 2019

See #1134.

@crummel crummel closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants