Make PhpUnit more verbose when tests have warnings

GeniJaho · GeniJaho · commit 440c2babfece · 2025-04-23T00:49:58.000+02:00
diff --git a/phpunit.xml b/phpunit.xml
@@ -6,6 +6,7 @@
     colors="true"
     executionOrder="defects"
     cacheDirectory=".phpunit.cache"
+    displayDetailsOnTestsThatTriggerWarnings="true"
 >
     <testsuites>
         <testsuite name="main">
diff --git a/src/Rector/MethodCall/EloquentOrderByToLatestOrOldestRector.php b/src/Rector/MethodCall/EloquentOrderByToLatestOrOldestRector.php
@@ -112,7 +112,9 @@ private function isOrderByMethodCall(MethodCall $methodCall): bool
 
     private function isAllowedPattern(MethodCall $methodCall): bool
     {
-        $columnArg = $methodCall->args[0] instanceof Arg ? $methodCall->args[0]->value : null;
+        $columnArg = $methodCall->args !== [] && $methodCall->args[0] instanceof Arg
+            ? $methodCall->args[0]->value
+            : null;
 
         // If no patterns are specified, consider all column names as matching
         if ($this->allowedPatterns === []) {

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`colors="true"`
`7`	`7`	`executionOrder="defects"`
`8`	`8`	`cacheDirectory=".phpunit.cache"`
	`9`	`+ displayDetailsOnTestsThatTriggerWarnings="true"`
`9`	`10`	`>`
`10`	`11`	`<testsuites>`
`11`	`12`	`<testsuite name="main">`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,9 @@ private function isOrderByMethodCall(MethodCall $methodCall): bool`
`112`	`112`
`113`	`113`	`private function isAllowedPattern(MethodCall $methodCall): bool`
`114`	`114`	`{`
`115`		`- $columnArg = $methodCall->args[0] instanceof Arg ? $methodCall->args[0]->value : null;`
	`115`	`+ $columnArg = $methodCall->args !== [] && $methodCall->args[0] instanceof Arg`
	`116`	`+ ? $methodCall->args[0]->value`
	`117`	`+ : null;`
`116`	`118`
`117`	`119`	`// If no patterns are specified, consider all column names as matching`
`118`	`120`	`if ($this->allowedPatterns === []) {`