Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GitHub enterprise #37

Closed
lcmgh opened this issue Apr 19, 2022 · 3 comments · Fixed by #46
Closed

Add support for GitHub enterprise #37

lcmgh opened this issue Apr 19, 2022 · 3 comments · Fixed by #46
Assignees
@dsaltares
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lcmgh
Copy link

lcmgh commented Apr 19, 2022

There is no option to use the current GitHub server as always github.com is being used.
@dsaltares dsaltares changed the title GitHub enterprise is not supported Add support for GitHub enterprise Apr 19, 2022
@dsaltares dsaltares added enhancement New feature or request help wanted Extra attention is needed labels Apr 19, 2022
@dsaltares
Copy link
Owner

Thanks for the issue @lcmgh, would love to see a PR for this, it sounds like a great addition. I had no idea Github Enterprise folks would be interested in this action.

@dsaltares
Copy link
Owner

Looks like octokit lets you pass a baseUrl to hit your GH enterprise instance: https://github.com/octokit/octokit.js/#constructor-options.

Will take a look.

@dsaltares dsaltares self-assigned this May 8, 2022
@dsaltares dsaltares mentioned this issue May 8, 2022
Merged
@dsaltares
Copy link
Owner

@lcmgh #46 should solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsaltares dsaltares

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 37 - add support for Github Enterprise dsaltares/fetch-gh-release-asset
2 participants
@dsaltares @lcmgh