Skip to content

Commit 6db6954

Browse files
committed
fix(common): adds loading prop to text-fields and change default align
1 parent 95e4054 commit 6db6954

File tree

2 files changed

+29
-23
lines changed

2 files changed

+29
-23
lines changed

src/components/common/typography/TextField.vue

+13-3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ defineProps({
2424
type: [String, Number, Boolean],
2525
required: false,
2626
},
27+
loading: {
28+
type: Boolean,
29+
required: false,
30+
default: false,
31+
},
2732
flex: {
2833
type: String,
2934
required: false,
@@ -62,7 +67,7 @@ defineProps({
6267
align: {
6368
type: String,
6469
required: false,
65-
default: 'baseline',
70+
default: 'center',
6671
},
6772
size: {
6873
type: String as PropType<'small' | 'medium' | 'large'>,
@@ -94,7 +99,7 @@ const { openTab } = useLinksStore();
9499
</slot>
95100
<slot>
96101
<NFlex v-if="array" wrap align="center" :title="title">
97-
<template v-if="values !== undefined">
102+
<template v-if="!loading && values !== undefined">
98103
<TagLinkComponent
99104
v-for="(tag, i) of values"
100105
:key="i"
@@ -109,7 +114,12 @@ const { openTab } = useLinksStore();
109114
</template>
110115
</NFlex>
111116
<template v-else>
112-
<span v-if="value !== undefined" class="value" :class="{ pre }" :title="title">
117+
<span
118+
v-if="!loading && value !== undefined"
119+
class="value"
120+
:class="{ pre }"
121+
:title="title"
122+
>
113123
{{ value }}
114124
</span>
115125
<NSkeleton v-else :repeat="pre ? 3 : 0" round v-bind="skeleton" />

src/components/views/settings/SettingsAccount.vue

+16-20
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { useI18n } from '~/utils/i18n.utils';
2626
const i18n = useI18n('settings', 'account');
2727
2828
const { fetchUserStats } = useUserSettingsStore();
29-
const { userSetting, user, userSettingLoading, userStat, userStatLoading } =
29+
const { userSetting, user, userStat, userSettingLoading, userStatLoading } =
3030
useUserSettingsStoreRefs();
3131
const { logout } = useLogout();
3232
@@ -188,8 +188,8 @@ onDeactivated(() => {
188188
</NCard>
189189

190190
<NCard class="account-card" :style="{ '--n-border-color': 'var(--border-color)' }">
191-
<NFlex class="data-card" size="large" wrap>
192-
<NFlex vertical class="flex-column">
191+
<NFlex class="limit-card" size="large" wrap>
192+
<NFlex vertical class="flex-column" style="flex-basis: 16rem">
193193
<TextField
194194
:label="i18n('user_lists_maximum')"
195195
:value="limits?.list?.count"
@@ -203,7 +203,7 @@ onDeactivated(() => {
203203
label-width="9.75rem"
204204
/>
205205
</NFlex>
206-
<NFlex vertical class="flex-column">
206+
<NFlex vertical class="flex-column" style="flex-basis: 12rem">
207207
<TextField
208208
:label="i18n('watchlist_max')"
209209
:value="limits?.watchlist?.item_count"
@@ -229,14 +229,13 @@ onDeactivated(() => {
229229
</NFlex>
230230

231231
<NCard class="account-card" :style="{ '--n-border-color': 'var(--border-color)' }">
232-
<NFlex class="data-card" size="large" vertical wrap>
232+
<NFlex class="stats-card" size="large" vertical wrap>
233233
<NFlex class="flex-auto" wrap>
234234
<TextField
235235
:label="i18n('user_stats_movies_watched')"
236236
:value="userStat?.movies?.watched ?? '-'"
237237
:loading="userStatLoading"
238238
label-width="8rem"
239-
grow
240239
/>
241240

242241
<TextField
@@ -247,7 +246,6 @@ onDeactivated(() => {
247246
:value="movieWatchTime"
248247
:loading="userStatLoading"
249248
label-width="8rem"
250-
grow
251249
/>
252250
</NFlex>
253251
<NFlex class="flex-auto" wrap>
@@ -256,7 +254,6 @@ onDeactivated(() => {
256254
:value="userStat?.episodes?.watched ?? '-'"
257255
:loading="userStatLoading"
258256
label-width="8rem"
259-
grow
260257
/>
261258
<TextField
262259
:label="i18n('user_stats_episodes_time')"
@@ -266,7 +263,6 @@ onDeactivated(() => {
266263
:value="episodeWatchTime"
267264
:loading="userStatLoading"
268265
label-width="8rem"
269-
grow
270266
/>
271267
</NFlex>
272268

@@ -276,56 +272,50 @@ onDeactivated(() => {
276272
:value="userStat?.shows?.watched ?? '-'"
277273
:loading="userStatLoading"
278274
label-width="8rem"
279-
grow
280275
/>
281276
<TextField
282277
:label="i18n('user_stats_total_time')"
283278
:value="totalWatchTime"
284279
:loading="userStatLoading"
285280
label-width="8rem"
286-
grow
287281
/>
288282
</NFlex>
289283
</NFlex>
290284
</NCard>
291285

292286
<NCard class="account-card" :style="{ '--n-border-color': 'var(--border-color)' }">
293-
<NFlex class="data-card" size="large" vertical wrap>
287+
<NFlex class="stats-card" size="large" vertical wrap>
294288
<NFlex class="flex-auto" wrap>
295289
<TextField
296290
:label="i18n('user_stats_episodes_collected')"
297291
:value="userStat?.episodes?.collected ?? '-'"
298292
:loading="userStatLoading"
299293
label-width="8rem"
300-
grow
301294
/>
302295
<TextField
303296
:label="i18n('user_stats_movies_collected')"
304297
:value="userStat?.movies?.collected ?? '-'"
305298
:loading="userStatLoading"
306299
label-width="8rem"
307-
grow
308300
/>
309301
</NFlex>
310302
</NFlex>
311303
</NCard>
312304

313305
<NCard class="account-card" :style="{ '--n-border-color': 'var(--border-color)' }">
314-
<NFlex class="data-card" size="large" vertical wrap>
306+
<NFlex class="stats-card" size="large" vertical wrap>
315307
<NFlex class="flex-auto" wrap>
316308
<TextField
317309
:label="i18n('user_stats_show_ratings')"
318310
:value="userStat?.shows?.ratings"
319311
:loading="userStatLoading"
320312
label-width="8rem"
321-
grow
322313
/>
323314
<TextField
324315
:label="i18n('user_stats_episodes_ratings')"
325316
:value="userStat?.episodes?.ratings"
326317
:loading="userStatLoading"
327318
label-width="8rem"
328-
grow
329319
/>
330320
</NFlex>
331321

@@ -335,14 +325,12 @@ onDeactivated(() => {
335325
:value="userStat?.movies?.ratings"
336326
:loading="userStatLoading"
337327
label-width="8rem"
338-
grow
339328
/>
340329
<TextField
341330
:label="i18n('user_stats_ratings')"
342331
:value="userStat?.ratings?.total"
343332
:loading="userStatLoading"
344333
label-width="8rem"
345-
grow
346334
/>
347335
</NFlex>
348336
</NFlex>
@@ -405,16 +393,24 @@ onDeactivated(() => {
405393
@extend %flex-auto;
406394
407395
min-width: max-content;
396+
height: 100%;
408397
}
409398
}
410399
411-
.data-card {
400+
.limit-card {
412401
:deep(.detail) {
413402
flex-basis: 31%;
414403
min-width: max-content;
415404
}
416405
}
417406
407+
.stats-card {
408+
:deep(.detail) {
409+
flex-basis: 42%;
410+
min-width: max-content;
411+
}
412+
}
413+
418414
.footer {
419415
margin-bottom: 0.5rem;
420416
padding: 0.5rem;

0 commit comments

Comments
 (0)