feat(bundle): move endpoint import to actual clients instead of base

Author: dvcol

src/services/tmdb-client/clients/base-tmdb-client.ts

@@ -11,10 +11,10 @@ import type {
   TmdbClientSettings,
   TmdbPaginatedData,
 } from '~/models/tmdb/tmdb-client.model';
+import type { tmdbApi } from '~/services/tmdb-client/api/tmdb-api.endpoint';
 
 import { TraktApiHeaders } from '~/models/trakt/trakt-client.model';
 import { BaseApiHeaders, type BaseBody, BaseClient, BaseHeaderContentType, parseBody, parseUrl } from '~/services/common/base-client';
-import { tmdbApi } from '~/services/tmdb-client/api/tmdb-api.endpoint';
 
 /**
  * The extracted type signature of the TmdbApi
@@ -65,7 +65,7 @@ export class BaseTmdbClient
    * @param authentication - The authentication for the client.
    * @param api - The API endpoints for the client.
    */
-  constructor(options: TmdbClientOptions, authentication: TmdbClientAuthentication = {}, api: ITmdbApi = tmdbApi) {
+  constructor(options: TmdbClientOptions, authentication: TmdbClientAuthentication = {}, api: ITmdbApi = {}) {
     super(options, authentication, api);
   }
 

src/services/tmdb-client/clients/tmdb-client.ts

@@ -1,5 +1,6 @@
-import type { TmdbClientAuthentication } from '~/models/tmdb/tmdb-client.model';
+import type { TmdbClientAuthentication, TmdbClientSettings } from '~/models/tmdb/tmdb-client.model';
 
+import { tmdbApi } from '~/services/tmdb-client/api/tmdb-api.endpoint';
 import { BaseTmdbClient } from '~/services/tmdb-client/clients/base-tmdb-client';
 import { Config } from '~/settings/tmdb.api';
 
@@ -11,6 +12,15 @@ import { Config } from '~/settings/tmdb.api';
  * @extends {BaseTmdbClient}
  */
 export class TmdbClient extends BaseTmdbClient {
+  /**
+   * Creates an instance of TmdbClient, with the necessary endpoints and settings.
+   * @param settings - The settings for the client.
+   * @param authentication - The authentication for the client.
+   */
+  constructor(settings: TmdbClientSettings, authentication: TmdbClientAuthentication = {}) {
+    super(settings, authentication, tmdbApi);
+  }
+
   /**
    * This is step #1 from the [user authentication]{@link https://developer.themoviedb.org/v4/docs/authentication-user} page.
    *

src/services/trakt-client/clients/base-trakt-client.ts

@@ -9,12 +9,11 @@ import type {
   TraktClientSettings,
 } from '~/models/trakt/trakt-client.model';
 
+import type { traktApi } from '~/services/trakt-client/api/trakt-api.endpoints';
 import type { Primitive } from '~/utils/typescript.utils';
 
 import { TraktApiHeaders } from '~/models/trakt/trakt-client.model';
-
 import { type BaseBody, BaseClient, BaseHeaderContentType, parseBody, parseUrl } from '~/services/common/base-client';
-import { traktApi } from '~/services/trakt-client/api/trakt-api.endpoints';
 import { isFilter, TraktApiFilterValidator } from '~/services/trakt-client/api/trakt-api.filters';
 
 /**
@@ -125,7 +124,7 @@ export class BaseTraktClient
    * @param authentication - The authentication for the client.
    * @param api - The API endpoints for the client.
    */
-  constructor(options: TraktClientOptions, authentication: TraktClientAuthentication = {}, api: ITraktApi = traktApi) {
+  constructor(options: TraktClientOptions, authentication: TraktClientAuthentication = {}, api: ITraktApi = {}) {
     super(options, authentication, api);
   }
 

src/services/trakt-client/clients/trakt-client.ts

@@ -10,9 +10,10 @@ import type {
   TraktClientAuthentication,
   TraktDeviceAuthentication,
 } from '~/models/trakt/trakt-authentication.model';
-import type { TraktApiInit, TraktApiResponse } from '~/models/trakt/trakt-client.model';
+import type { TraktApiInit, TraktApiResponse, TraktClientSettings } from '~/models/trakt/trakt-client.model';
 
 import { TraktApiHeaders } from '~/models/trakt/trakt-client.model';
+import { traktApi } from '~/services/trakt-client/api/trakt-api.endpoints';
 import { randomHex } from '~/utils/crypto.utils';
 
 /**
@@ -49,6 +50,15 @@ const handleError = <T>(error: T | Response) => {
 export class TraktClient extends BaseTraktClient {
   private polling: ReturnType<typeof setTimeout> | undefined;
 
+  /**
+   * Creates an instance of TraktClient, with the necessary endpoints and settings.
+   * @param settings - The settings for the client.
+   * @param authentication - The authentication for the client.
+   */
+  constructor(settings: TraktClientSettings, authentication: TraktClientAuthentication = {}) {
+    super(settings, authentication, traktApi);
+  }
+
   /**
    * Exchanges an authorization code or refresh token for an access token.
    *

src/services/tvdb-client/clients/base-tvdb-client.ts

@@ -9,10 +9,10 @@ import type {
   TvdbClientOptions,
   TvdbClientSettings,
 } from '~/models/tvdb/tvdb-client.model';
+import type { tvdbApi } from '~/services/tvdb-client/api/tvdb-api.endpoint';
 
 import { TraktApiHeaders } from '~/models/trakt/trakt-client.model';
 import { BaseApiHeaders, type BaseBody, BaseClient, BaseHeaderContentType, parseBody, parseUrl } from '~/services/common/base-client';
-import { tvdbApi } from '~/services/tvdb-client/api/tvdb-api.endpoint';
 
 /**
  * The extracted type signature of the TvdbApi
@@ -39,7 +39,7 @@ export class BaseTvdbClient
    * @param authentication - The authentication for the client.
    * @param api - The API endpoints for the client.
    */
-  constructor(options: TvdbClientOptions, authentication: TvdbClientAuthentication = {}, api: ITvdbApi = tvdbApi) {
+  constructor(options: TvdbClientOptions, authentication: TvdbClientAuthentication = {}, api: ITvdbApi = {}) {
     super(options, authentication, api);
   }
 

src/services/tvdb-client/clients/tvdb-client.ts

@@ -1,5 +1,6 @@
-import type { TvdbClientAuthentication } from '~/models/tvdb/tvdb-client.model';
+import type { TvdbClientAuthentication, TvdbClientSettings } from '~/models/tvdb/tvdb-client.model';
 
+import { tvdbApi } from '~/services/tvdb-client/api/tvdb-api.endpoint';
 import { BaseTvdbClient } from '~/services/tvdb-client/clients/base-tvdb-client';
 
 /**
@@ -10,6 +11,15 @@ import { BaseTvdbClient } from '~/services/tvdb-client/clients/base-tvdb-client'
  * @extends {BaseTvdbClient}
  */
 export class TvdbClient extends BaseTvdbClient {
+  /**
+   * Creates an instance of TvdbClient, with the necessary endpoints and settings.
+   * @param settings - The settings for the client.
+   * @param authentication - The authentication for the client.
+   */
+  constructor(settings: TvdbClientSettings, authentication: TvdbClientAuthentication = {}) {
+    super(settings, authentication, tvdbApi);
+  }
+
   /**
    * Authenticates the client with the setting's secret and an optionally provided user pin.
    * The access token is stored in the client and used for all subsequent requests.