fix(list): key element with date as there might be re-releases

Author: dvcol

src/components/common/list/use-list-scroll.ts

@@ -247,8 +247,8 @@ export const computeNewArray = <T extends ListScrollSourceItemWithDate<D>, D ext
     if (!_item.getPosterQuery) _item.getPosterQuery = getPosterQuery(item, _item.type);
     if (!_item.getProgressQuery) _item.getProgressQuery = getProgressQuery(item);
 
-    _item.key = `${_item.type}-${_item.id}`;
     _item.date = getDate(item, array, index, dateFn);
+    _item.key = `${_item.type}-${_item.id}-${_item.date?.current?.getTime()}`;
     _item.meta = {
       source: item,
       ids: {

src/models/pagination.model.ts

@@ -1,19 +1,15 @@
-import type { TmdbApiPagination } from '@dvcol/tmdb-http-client/dist/models/tmdb-client.model';
 import type { TraktClientPagination } from '@dvcol/trakt-http-client/models';
 
-export type StorePagination = Partial<TraktClientPagination> | Partial<TmdbApiPagination>;
-export type LoadedStorePagination<T extends TraktClientPagination | TmdbApiPagination> = T &
-  ('pageCount' extends keyof T ? { page: number; pageCount: number } : { page: number; total_pages: number });
+export type StorePagination = Partial<TraktClientPagination>;
 
-export const pageLoaded = <T extends TraktClientPagination | TmdbApiPagination>(pagination?: T) => {
+export const pageLoaded = (pagination?: StorePagination) => {
   if (!pagination) return false;
-  const { page, pageCount, total_pages } = pagination;
-  const _total = total_pages ?? pageCount;
-  if (page === undefined || _total === undefined) return false;
-  if (_total === 0) return true;
-  return page >= _total;
+  const { page, pageCount: total } = pagination;
+  if (page === undefined || total === undefined) return false;
+  if (total === 0) return true;
+  return page >= total;
 };
 
-export const pageNotLoaded = <T extends TraktClientPagination | TmdbApiPagination>(pagination?: T) => {
+export const pageNotLoaded = (pagination?: StorePagination) => {
   return !pageLoaded(pagination);
 };

src/stores/data/ratings.store.ts

@@ -10,7 +10,7 @@ import { defineStore, storeToRefs } from 'pinia';
 import { computed, reactive, ref } from 'vue';
 
 import { PageSize } from '~/models/page-size.model';
-import { pageLoaded, type StorePagination } from '~/models/pagination.model';
+import { pageLoaded, pageNotLoaded, type StorePagination } from '~/models/pagination.model';
 
 import { ErrorService } from '~/services/error.service';
 import { Logger } from '~/services/logger.service';
@@ -229,7 +229,7 @@ export const useRatingsStore = defineStore(RatingsStoreConstants.Store, () => {
 
   const loadRatings = async <T extends TraktRatingTypes>(type: T, id: string): Promise<TraktRatingsReturn<T> | undefined> => {
     while (
-      !pageLoaded(paginations[type]) &&
+      pageNotLoaded(paginations[type]) &&
       !getLoading(type) &&
       !getRatings(type, id) &&
       shouldRetry(errors[JSON.stringify(getQuery(type))], { error: `Ratings for ${type} - ${id.toString()}` })