Skip to content

Commit 9283fd0

Browse files
committed
fix(listener): switch to passive listeners
1 parent 612e94d commit 9283fd0

File tree

5 files changed

+11
-17
lines changed

5 files changed

+11
-17
lines changed

src/components/AppComponent.vue

+3-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<script setup lang="ts">
22
import { NDialogProvider, NDrawer } from 'naive-ui';
3-
import { onBeforeUnmount, onMounted, ref, Transition, watch } from 'vue';
3+
import { ref, Transition, watch } from 'vue';
44
import { RouterView, useRouter } from 'vue-router';
55
66
import GridBackground from '~/components/common/background/GridBackground.vue';
@@ -59,13 +59,6 @@ const onBack = () => {
5959
if (window.history.state.back) return back();
6060
return onClose();
6161
};
62-
63-
onMounted(() => {
64-
mainRef.value?.addEventListener('touchstart', NavbarService.hideDrawer);
65-
});
66-
onBeforeUnmount(() => {
67-
mainRef.value?.removeEventListener('touchstart', NavbarService.hideDrawer);
68-
});
6962
</script>
7063

7164
<template>
@@ -96,7 +89,8 @@ onBeforeUnmount(() => {
9689
<RouterView v-slot="{ Component }">
9790
<main
9891
ref="mainRef"
99-
:class="{ 'full-height': !isAuthenticated, loading: !Component }"
92+
:class="{ 'full-height': !isAuthenticated, 'loading': !Component }"
93+
@touchstart.passive="NavbarService.hideDrawer"
10094
>
10195
<GridBackground v-if="!Component" :size="20" />
10296
<Transition name="scale" mode="out-in">

src/components/common/navbar/NavbarComponent.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@ const onTouchEnd = (e: TouchEvent) => {
172172
@mouseleave="isHover = false"
173173
@focusin="isFocus = true"
174174
@focusout="isFocus = false"
175-
@touchend="onTouchEnd"
176-
@touchstart="onTouchStart"
175+
@touchend.passive="onTouchEnd"
176+
@touchstart.passive="onTouchStart"
177177
>
178178
<NTabs
179179
:key="enabledRoutes.join('-')"

src/components/common/numbers/ProgressNumber.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,8 @@ onBeforeUnmount(() => {
240240
@keydown.up.prevent="onProgress(emitProgress + progressStep)"
241241
@keydown.down.prevent="onProgress(emitProgress - progressStep)"
242242
@keydown.esc="onBlur"
243-
@touchstart="onClick"
244-
@touchend="onClick"
243+
@touchstart.passive="onClick"
244+
@touchend.passive="onClick"
245245
@blur="onBlur"
246246
>
247247
<span v-if="editing">{{ emitProgress }}</span>

src/components/views/panel/PanelContent.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ const onTouchEnd = (e: TouchEvent) => {
3737
<template>
3838
<NDrawerContent
3939
:native-scrollbar="false"
40-
@touchstart="onTouchStart"
41-
@touchend="onTouchEnd"
40+
@touchstart.passive="onTouchStart"
41+
@touchend.passive="onTouchEnd"
4242
>
4343
<!-- Header -->
4444
<NFlex justify="space-between" class="panel-header">

src/components/views/panel/PanelTrailers.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ const onTouchEnd = (e: TouchEvent) => {
5656
keyboard
5757
trigger="hover"
5858
:space-between="32"
59-
@touchstart="onTouchStart"
60-
@touchend="onTouchEnd"
59+
@touchstart.passive="onTouchStart"
60+
@touchend.passive="onTouchEnd"
6161
>
6262
<slot />
6363
<YoutubePlayer

0 commit comments

Comments
 (0)