fix(progress): fix percentages and hide tooltips when no aired episodes

Author: dvcol

src/components/views/panel/ShowPanelButtons.vue

@@ -112,6 +112,16 @@ const watchedPercentage = computed(() => {
   return watched.value ? 100 : 0;
 });
 
+const hadAiredWatched = computed(() => {
+  const _progress = watchedProgress?.value;
+  if (!_progress) return false;
+  return 'aired' in _progress && _progress.aired > 0;
+});
+
+const disableWatchedTooltip = computed(() => {
+  return !['show', 'season'].includes(mode.value) || !hadAiredWatched.value;
+});
+
 const collected = computed(() => {
   const _progress = collectionProgress?.value;
   if (_progress === undefined) return;
@@ -125,6 +135,16 @@ const collectionPercentage = computed(() => {
   return collected.value ? 100 : 0;
 });
 
+const hadAiredCollection = computed(() => {
+  const _progress = collectionProgress?.value;
+  if (!_progress) return false;
+  return 'aired' in _progress && _progress.aired > 0;
+});
+
+const disableCollectionTooltip = computed(() => {
+  return !['show', 'season'].includes(mode.value) || !hadAiredCollection.value;
+});
+
 const i18n = useI18n('panel', 'buttons');
 
 const root = ref<HTMLDivElement>();
@@ -222,7 +242,7 @@ onMounted(() => {
           options: collectionOptions,
         }"
         :tooltip="{
-          disabled: !['show', 'season'].includes(mode),
+          disabled: disableCollectionTooltip,
           type: 'collection',
         }"
         :icon="collected ? IconGrid : IconGridEmpty"
@@ -244,7 +264,7 @@ onMounted(() => {
           options: watchedOptions,
         }"
         :tooltip="{
-          disabled: !['show', 'season'].includes(mode),
+          disabled: disableWatchedTooltip,
         }"
         :icon="watched ? IconPlayFilled : IconPlay"
         :progress="watchedProgress"

src/stores/data/show.store.ts

@@ -38,14 +38,13 @@ const watchProgressToListProgress = (progress: TraktWatchedProgress | TraktColle
     date: new Date('last_watched_at' in progress ? progress.last_watched_at : progress.last_collected_at),
     seasons: progress.seasons.map(season => {
       if (season.number > 0) {
-        completed += season.completed;
-        aired += season.aired;
+        if (season.completed) completed += season.completed;
+        if (season.aired) aired += season.aired;
       }
-
       return {
         ...season,
-        percentage: (season.completed / season.aired) * 100,
-        finished: season.completed === season.aired,
+        percentage: season.aired ? ((season.completed ?? 0) / season.aired) * 100 : 0,
+        finished: !!season.aired && season.completed === season.aired,
         episodes: season.episodes.map(episode => ({
           ...episode,
           date: new Date('last_watched_at' in episode ? episode.last_watched_at : episode.collected_at),
@@ -57,8 +56,8 @@ const watchProgressToListProgress = (progress: TraktWatchedProgress | TraktColle
     ...result,
     completed,
     aired,
-    percentage: (completed / aired) * 100,
-    finished: completed === aired,
+    percentage: aired ? ((completed ?? 0) / aired) * 100 : 0,
+    finished: !!aired && completed === aired,
   };
 };