fix(base-client): fix falsy filter for param interpolation

Author: dvcol

src/services/common/base-client.ts

@@ -567,7 +567,7 @@ export const parseUrl = <P extends RecursiveRecord = RecursiveRecord, O extends
         }
         return segment;
       })
-      .filter(Boolean)
+      .filter(_segment => ![undefined, null, ''].includes(_segment))
       .join('/');
   }
 

src/services/trakt-client/api/endpoints/seasons.endpoint.ts

@@ -62,7 +62,7 @@ export const seasons = {
   season: new TraktClientEndpoint<
     {
       /** Trakt ID, Trakt slug, or IMDB ID */
-      id: string;
+      id: string | number;
       /** season number */
       season: number;
       /** include episode translations - 2 character language code (ISO 639-1) */

src/services/trakt-client/clients/base-trakt-client.ts

@@ -192,9 +192,11 @@ export class BaseTraktClient extends BaseClient<TraktApiQuery, TraktApiResponse,
     }
 
     // Extended
-    if (template.opts?.extended && params.extended) {
-      if (!template.opts.extended.includes(params.extended)) {
-        throw Error(`Invalid value '${params.extended}', extended should be '${template.opts.extended}'`);
+    if (template.opts?.extended?.length && params.extended) {
+      const templateExtended = template.opts.extended;
+      const paramsExtended = Array.isArray(params.extended) ? params.extended : [params.extended];
+      if (paramsExtended.some(e => !templateExtended.includes(e))) {
+        throw Error(`Invalid value '${params.extended}', extended should be '${template.opts.extended.join(', ')}'`);
       }
       queryParams.set('extended', `${params.extended}`);
     }