fix for issue #596

cope with signals without receiver

Author: Eduard Bröcker

src/canmatrix/formats/dbc.py

@@ -551,11 +551,15 @@ def add_frame_by_id(new_frame):  # type: (canmatrix.Frame) -> None
                 db.frames.append(frame)
                 add_frame_by_id(frame)
             elif decoded.startswith("SG_ "):
+                original_line = l
+                if decoded.strip().endswith(r'"'):
+                    decoded += r" Vector__XXX"
+                    original_line += b" Vector__XXX"
                 pattern = r"^SG_ +(\w+) *: *(\d+)\|(\d+)@(\d+)([\+|\-]) *\(([0-9.+\-eE]+), *([0-9.+\-eE]+)\) *\[([0-9.+\-eE]+)\|([0-9.+\-eE]+)\] +\"(.*)\" +(.*)"
                 regexp = re.compile(pattern)
                 temp = regexp.match(decoded)
                 regexp_raw = re.compile(pattern.encode(dbc_import_encoding))
-                temp_raw = regexp_raw.match(l)
+                temp_raw = regexp_raw.match(original_line)
                 if temp:
                     receiver = [b.strip() for b in temp.group(11).split(',')]
 
@@ -587,7 +591,7 @@ def add_frame_by_id(new_frame):  # type: (canmatrix.Frame) -> None
                     regexp = re.compile(pattern)
                     regexp_raw = re.compile(pattern.encode(dbc_import_encoding))
                     temp = regexp.match(decoded)
-                    temp_raw = regexp_raw.match(l)
+                    temp_raw = regexp_raw.match(original_line)
                     receiver = [b.strip() for b in temp.group(12).split(',')]
                     multiplex = temp.group(2)  # type: str
 

src/canmatrix/tests/test_dbc.py

@@ -508,3 +508,11 @@ def test_float_cycle_time():
     assert matrix.frames[0].cycle_time == 100
 
 
+def test_without_ecu():
+    dbc = io.BytesIO(textwrap.dedent(u'''\
+            BO_ 17 Frame_1: 8 Vector__XXX
+            SG_ A_B_C_D_E: 39|16@0+ (0.01,0) [0|655.35] "km/h"
+    ''').encode('utf-8'))
+
+    matrix = canmatrix.formats.dbc.load(dbc, dbcImportEncoding="utf8")
+    matrix.frames[0].signals[0].name == "A_B_C_D_E"

src/canmatrix/utils.py

@@ -114,7 +114,8 @@ def decode_number(value, float_factory):  # type(string) -> (int)
     :param value: string input value
     :return: integer
     """
-
+    if value is None:
+        return 0
     value = value.strip()
 
     if '.' in value: