Iss496 (#511)

* #496 fix ignore encoding switch
* clean encoding error implementation

Author: ebroecker

src/canmatrix/cli/convert.py

@@ -130,7 +130,7 @@ def cli_convert(infile, outfile, silent, verbosity, **options):
     if options["ignoreEncodingErrors"]:
         options["ignoreEncodingErrors"] = "ignore"
     else:
-        options["ignoreEncodingErrors"] = ""
+        options["ignoreEncodingErrors"] = "strict"
 
     canmatrix.convert.convert(infile, outfile, **options)
     return 0

src/canmatrix/formats/arxml.py

@@ -1848,9 +1848,9 @@ def decode_can_helper(ea, float_factory, ignore_cluster_info):
         else:  # find signal senders/receivers...
             isignal_triggerings = ea.find_children_by_path(physical_channel, "I-SIGNAL-TRIGGERING")
             for sig_trig in isignal_triggerings:
-                isignal = ea.follow_ref(sig_trig, 'SIGNAL-REF')
+                isignal = ea.follow_ref(sig_trig, 'SIGNAL-REF') # AR 3.2
                 if isignal is None:
-                    isignal = ea.follow_ref(sig_trig, 'I-SIGNAL-REF')
+                    isignal = ea.follow_ref(sig_trig, 'I-SIGNAL-REF') # AR4
                 if isignal is None:
                     sig_trig_text = ea.get_element_name(sig_trig) if sig_trig is not None else "None"
                     logger.debug("load: no isignal for %s", sig_trig_text)

src/canmatrix/formats/dbf.py

@@ -316,7 +316,7 @@ def dump(mydb, f, **options):
     # create copy because export changes database
     db = copy.deepcopy(mydb)
     dbf_export_encoding = options.get("dbfExportEncoding", 'iso-8859-1')
-    ignore_encoding_errors = options.get("ignoreEncodingErrors", "")
+    ignore_encoding_errors = options.get("ignoreEncodingErrors", "strict")
     db.enum_attribs_to_keys()
     if len(db.signals) > 0:
         free_signals_dummy_frame = canmatrix.Frame("VECTOR__INDEPENDENT_SIG_MSG")

src/canmatrix/formats/sym.py

@@ -193,7 +193,7 @@ def dump(db, f, **options):  # type: (canmatrix.CanMatrix, typing.IO, **typing.A
     export canmatrix-object as .sym file (compatible to PEAK-Systems)
     """
     sym_encoding = options.get('symExportEncoding', 'iso-8859-1')
-    ignore_encoding_errors = options.get("ignoreEncodingErrors", "")
+    ignore_encoding_errors = options.get("ignoreEncodingErrors", "strict")
 
     enum_dict = {}
     for enum_name, enum_values in db.value_tables.items():