let dbc replace not known attibute-defines by STRING #284

Author: ebroecker

src/canmatrix/dbc.py

@@ -63,6 +63,13 @@ def format_float(f):
     return s.upper()
 
 
+def check_define(define):
+    # check if define is compatible with dbc. else repace by STRING
+    if define.type not in ["ENUM", "STRING", "INT", "HEX", "FLOAT"]:
+        logger.warn("dbc export of attribute type {} not supported; replaced by STRING".format(define.type))
+        define.definition = "STRING"
+
+
 def dump(mydb, f, **options):
     # create copy because export changes database
     db = deepcopy(mydb)
@@ -289,7 +296,9 @@ def dump(mydb, f, **options):
     f.write("\n".encode(dbcExportEncoding))
 
     defaults = {}
+
     for (dataType, define) in sorted(list(db.frameDefines.items())):
+        check_define(define)
         f.write(
             ('BA_DEF_ BO_ "' +  dataType + '" ').encode(dbcExportEncoding) + define.definition.encode(dbcExportEncoding, 'replace') + ';\n'.encode(dbcExportEncoding))
         if dataType not in defaults and define.defaultValue is not None:
@@ -299,6 +308,7 @@ def dump(mydb, f, **options):
                 defaults[dataType] = define.defaultValue
 
     for (dataType, define) in sorted(list(db.signalDefines.items())):
+        check_define(define)
         f.write(
             ('BA_DEF_ SG_ "' + dataType + '" ').encode(dbcExportEncoding) +
             define.definition.encode(dbcExportEncoding, 'replace') + ';\n'.encode(dbcExportEncoding))
@@ -308,6 +318,7 @@ def dump(mydb, f, **options):
             else:
                 defaults[dataType] = define.defaultValue
     for (dataType, define) in sorted(list(db.buDefines.items())):
+        check_define(define)
         f.write(
             ('BA_DEF_ BU_ "' + dataType + '" ').encode(dbcExportEncoding) +
             define.definition.encode(dbcExportEncoding, 'replace') + ';\n'.encode(dbcExportEncoding))
@@ -317,6 +328,7 @@ def dump(mydb, f, **options):
             else:
                 defaults[dataType] = define.defaultValue
     for (dataType, define) in sorted(list(db.globalDefines.items())):
+        check_define(define)
         f.write(('BA_DEF_ "' + dataType + '" ').encode(dbcExportEncoding) + define.definition.encode(dbcExportEncoding, 'replace') + ';\n'.encode(dbcExportEncoding))
         if dataType not in defaults and define.defaultValue is not None:
             if define.type == "ENUM" or define.type == "STRING":