Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dbc <=> xlsx - DLC is always reset to it's maximum of 8 bytes #768

Closed
nexulm opened this issue Feb 16, 2024 · 3 comments
Closed
Assignees

Comments

@nexulm
Copy link

nexulm commented Feb 16, 2024

During the conversion of dbc to xls and vice versa all CAN messages are resetted to max DLC of 8 bytes.

Input;
Standard-CAN dbc

Command used with Ubuntu Linux 22.04:
python3 -m canmatrix.cli.convert "$path/$param_file_wo_extension.dbc" "$path/$param_file_wo_extension.xlsx"

Is there any option I've missed to avoid resetting the current DLC length (i.e. DLC =3) to the max possible DLC bytes of 8?
Since I'm using Canmatrix to convert the DBC, edit the entries in Excel and create an updated DBC from it, the observed behavior is not helpful.

@ebroecker
Copy link
Owner

same here:
xls(x) is lossy, but you can add additional Attributes:
–additionalSignalAttributes//–additionalFrameAttributes

@ebroecker ebroecker self-assigned this Feb 25, 2024
@nexulm
Copy link
Author

nexulm commented Jun 19, 2024

Is it really closed if the code has a fixed value of dlc = 8 at line 409 of xlsx.py ???
image

I've fixed this specific issue in my fork by using frame.size as input.
image

@ebroecker
Copy link
Owner

Hi @nexulm,

you are right, the root-cause is different - all additional attributes are not read anymore since I switched to openpyxl.
Will be fixed in #541 (which I just reopened)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants