Skip to content

Commit 8395825

Browse files
authored
test(ci): add early supported node versions to test matrix (#705)
Early versions of Node.js 8 had a regression around the handling of `null` as the port passed to `Server#listen()`. For details see: nodejs/node#14221
1 parent 0938282 commit 8395825

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.travis.yml

+4
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,13 @@ before_script:
2525

2626
node_js:
2727
- '11'
28+
- '11.0'
2829
- '10'
30+
- '10.0'
2931
- '8'
32+
- '8.1'
3033
- '6'
34+
- '6.0'
3135

3236
jobs:
3337
fast_finish: true

test/.jenkins_nodejs.yml

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
NODEJS_VERSION:
22
- "11"
3+
- "11.0"
34
- "10"
5+
- "10.0"
46
- "8"
7+
- "8.1"
58
- "6"
9+
- "6.0"

test/instrumentation/modules/restify.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ test('transaction name', function (t) {
3939

4040
// NOTE: Hostname must be supplied to force IPv4 mode,
4141
// otherwise this will use IPv6, which fails on Travis CI.
42-
server.listen(null, '0.0.0.0', function () {
42+
server.listen(0, '0.0.0.0', function () {
4343
const req = http.get(`${server.url}/hello/world`, res => {
4444
t.equal(res.statusCode, 200, 'server should respond with status code 200')
4545
const chunks = []
@@ -96,7 +96,7 @@ test('error reporting', function (t) {
9696

9797
// NOTE: Hostname must be supplied to force IPv4 mode,
9898
// otherwise this will use IPv6, which fails on Travis CI.
99-
server.listen(null, '0.0.0.0', function () {
99+
server.listen(0, '0.0.0.0', function () {
100100
const req = http.get(`${server.url}/hello/world`, res => {
101101
t.equal(res.statusCode, 500, 'server should respond with status code 500')
102102
res.resume()
@@ -149,7 +149,7 @@ test('error reporting from chained handler', function (t) {
149149

150150
// NOTE: Hostname must be supplied to force IPv4 mode,
151151
// otherwise this will use IPv6, which fails on Travis CI.
152-
server.listen(null, '0.0.0.0', function () {
152+
server.listen(0, '0.0.0.0', function () {
153153
const req = http.get(`${server.url}/hello/world`, res => {
154154
t.equal(res.statusCode, 500, 'server should respond with status code 500')
155155
res.resume()

0 commit comments

Comments
 (0)