Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user to task description #124252

Open
dnhatn opened this issue Mar 6, 2025 · 3 comments · May be fixed by #124584
Open

Add user to task description #124252

dnhatn opened this issue Mar 6, 2025 · 3 comments · May be fixed by #124584
Assignees
Labels
:Analytics/ES|QL AKA ESQL :Core/Infra/Core Core issues without another label :Security/Security Security issues without another label Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Core/Infra Meta label for core/infra team Team:Security Meta label for security team

Comments

@dnhatn
Copy link
Member

dnhatn commented Mar 6, 2025

Currently, we copy headers such as X-Opaque-Id, X-elastic-product-origin, etc., when creating a new task. In ES|QL, we would like to add the user to these headers so that we can identify which users are running heavy queries. However, we need to discuss the safety and feasibility before implementing the change.

  1. How sensitive is it to add the user to the task headers?
  2. We don't store the user directly in ThreadContext but rather the authentication token. Therefore, we need to deserialize when accessing the user, which can be expensive for every task/query.
  3. Should we add the user to all tasks or just ES|QL root task?
  4. An alternative is Kibana adding users when sending queries, and in Elasticsearch, we just add a new header for the user and copy it like the existing headers.

I might be missing something obvious here.

@dnhatn dnhatn added :Analytics/ES|QL AKA ESQL :Core/Infra/Core Core issues without another label :Security/Security Security issues without another label labels Mar 6, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Security Meta label for security team labels Mar 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@nik9000 nik9000 self-assigned this Mar 10, 2025
@nik9000 nik9000 linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL :Core/Infra/Core Core issues without another label :Security/Security Security issues without another label Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Core/Infra Meta label for core/infra team Team:Security Meta label for security team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants