Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting sandbox to false so that bytecode plugin works is a security threat #231

Open
kotasudhakar opened this issue Apr 16, 2024 · 2 comments

Comments

@kotasudhakar
Copy link

kotasudhakar commented Apr 16, 2024

I understand that it was asked to turn the sandbox option to false in order to protect source code using bytecode plugin as it uses the nodevm, however it is kinda dangerous tbh to do so although there are still other options like contextIsolation to prevent render process accessing the main process.

Can we do in any other alternative way so that we no need to set the sandbox value to false for browserWindow options and improving security? may be using something like Jailed/Hermes

https://electron-vite.org/guide/source-code-protection
image

@kotasudhakar
Copy link
Author

@yejimeiming
Copy link
Contributor

It is recommended that you use electron-vite instead of vite-plugin-electron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants