Swup Error

[garazdawi]

When navigating from https://erlang.org/docs/28 and clicking any of the application links (for example stdlib), sometimes swup crashes with the error below:

html-6VTPNSGQ.js:152 [swup] Container missing in incoming document: #main
(anonymous) @ html-6VTPNSGQ.js:152

Error: [swup] Container mismatch, aborting 
    at html-6VTPNSGQ.js:152:17234
    at html-6VTPNSGQ.js:152:5895
    at new Promise (<anonymous>)
    at _u (html-6VTPNSGQ.js:152:5869)
    at Bn.run (html-6VTPNSGQ.js:152:9618)
    at Bn.call (html-6VTPNSGQ.js:152:9064)
    at async Lt.Du [as renderPage] (html-6VTPNSGQ.js:152:17053)
    at async html-6VTPNSGQ.js:152:14707
    at async Bn.run (html-6VTPNSGQ.js:152:9612)
    at async Bn.call (html-6VTPNSGQ.js:152:9053)

As #2084 is not yet implemented, we are using html redirects to achieve the same thing which I assume is the reason why swup is not happy.

[josevalim]

I think you can add a fake #main element, but let's fix this by implementing #2084. I will submit a pull request today. :) I will close this one on behalf of that!

[garazdawi]

I just realized that we transitioned to use #1952, which is what generates pages without #main. Maybe that should also be updated to generate #main?

[josevalim]

@garazdawi in theory those do not need #main, because they are not meant to go to the sidebar, but I realized that they may be linked to through markdown anyway, so we need to fix it.

[josevalim]

@garazdawi I have emulated your use case here and it seems to work now. Please confirm and I can release a new version!

[garazdawi]

As I cannot reproduce the fault locally I deployed it here: https://garazdawi.github.io/otp/doc/readme.html

The fault as reported is fixed, but I noticed something different when navigating that is also broken.

If I click on "sasl" and then do "back" and then try to go to "sasl" again it fails, though not with any error. The page just doesn't go anywhere. This is also precent on https://erlang.org/doc/ though I did not notice it before. Your fixed changed this behaviour somewhat thoug, as now the URI reads "https://garazdawi.github.io/otp/doc/stdlib.html" instead of "https://garazdawi.github.io/otp/doc/readme.html" when I press "back".

[garazdawi]

The swup progress bar also gets stuck and never completes.

[josevalim]

@garazdawi it should be good now!

[josevalim]

Btw, you should be able to reproduce this locally by doing erl -S httpd serve directory-with-docs/ and then accessing it via a web server.

[garazdawi]

Now it works! Thanks!

[josevalim]

New version is out!