Respond to PR feedback:

- Added comment for NoWarn
- Change how Packages.props is imported
- Change how analyzers are imported
- fix sdks build
- remove fullframework true

Author: marcpopMSFT

Directory.Build.props

@@ -20,8 +20,9 @@
     <!-- Source build does not need to worry about running on VS for Mac -->
     <ResolverTargetFramework Condition="'$(DotNetBuildFromSource)' == 'true'">$(SdkTargetFramework)</ResolverTargetFramework>
 
-    <!-- Disable implicit package target fallback, and disable warning for when we explicitly add it (currently needed for
+    <!-- NU1701 Disable implicit package target fallback, and disable warning for when we explicitly add it (currently needed for
          Microsoft.ApplicationInsights) -->
+    <!-- NU1507 Disable multi-feed check as .NET uses multiple internal feeds intentionally -->
     <NoWarn>$(NoWarn);NU1701;NU1507</NoWarn>
     <!-- Temporarily NoWarn to avoid regression in preview 1.
          https://github.com/dotnet/roslyn-analyzers/pull/6236/files -->

Directory.Build.targets

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
 <Project>
-  <Import Project="$(RepositoryEngineeringDir)Packages.props" />
   <ItemGroup>
     <SupportedPlatform Remove="Android" />
     <SupportedPlatform Remove="iOS" />

Directory.Packages.props

@@ -1,5 +1,5 @@
 <Project>
   <ItemGroup Condition="'$(DotNetBuildFromSource)' != 'true'">
-    <PackageVersion Include="StyleCop.Analyzers" Version="$(StyleCopAnalyzersPackageVersion)" PrivateAssets="all" Condition="'$(EnableStyleCopAnalyzer)' == 'true'" />
+    <PackageReference Include="StyleCop.Analyzers" PrivateAssets="all" Condition="'$(EnableStyleCopAnalyzer)' == 'true'" />
   </ItemGroup>
 </Project>

eng/Analyzers.props

@@ -4,9 +4,9 @@
 
   <ItemGroup>
     <!--Test dependencies-->
-    <PackageVersion Update="Verify.Xunit" Version="20.4.0" />
-    <PackageVersion Update="Verify.DiffPlex" Version="2.2.1" />
-    <PackageVersion Update="FakeItEasy" Version="7.4.0" />
-    <PackageVersion Update="Wcwidth.Sources" Version="1.0.0" />
+    <PackageVersion Include="Verify.Xunit" Version="20.4.0" />
+    <PackageVersion Include="Verify.DiffPlex" Version="2.2.1" />
+    <PackageVersion Include="FakeItEasy" Version="7.4.0" />
+    <PackageVersion Include="Wcwidth.Sources" Version="1.0.0" />
   </ItemGroup>
 </Project>

eng/dependabot/Packages.props

@@ -18,7 +18,7 @@
     <!-- While in prerelease, ship the symbols to everyone all the time. -->
     <DebugType>embedded</DebugType>
     <Nullable>enable</Nullable>
-    <NoWarn>($NoWarn);CS8002;NU1507</NoWarn>
+    <NoWarn>$(NoWarn);CS8002</NoWarn>
     <StrongNameKeyId>MicrosoftShared</StrongNameKeyId>
     <SignAssembly>true</SignAssembly>
   </PropertyGroup>

src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj

@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="$(DependencyPackageName)" Version="$(DependencyPackageVersion)" />
+    <PackageReference Include="$(DependencyPackageName)" VersionOverride="$(DependencyPackageVersion)" />
   </ItemGroup>
 
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />

src/Layout/redist/targets/sdks/sdks.csproj

@@ -9,7 +9,7 @@ public class TestCommandLine
     {
         public List<string> RemainingArgs { get; private set; }
 
-        public bool UseFullFrameworkMSBuild { get; private set; } = true;
+        public bool UseFullFrameworkMSBuild { get; private set; }
 
         public string FullFrameworkMSBuildPath { get; private set; }