-
Notifications
You must be signed in to change notification settings - Fork 352
[WIP] S3 auth type kubernetes secret use aws envs in elyra cos jupyterlab #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] S3 auth type kubernetes secret use aws envs in elyra cos jupyterlab #3299
Conversation
…ata config, using env vars directly instead in Elyra Signed-off-by: shalberd <[email protected]>
Signed-off-by: shalberd <[email protected]>
…cos-user and cos-password arguments Signed-off-by: shalberd <[email protected]>
Signed-off-by: shalberd <[email protected]>
Signed-off-by: shalberd <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3299 +/- ##
=======================================
Coverage ? 83.74%
=======================================
Files ? 158
Lines ? 19939
Branches ? 505
=======================================
Hits ? 16698
Misses ? 3057
Partials ? 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I am now using the AWS S3 envs in Elyra itself, if, and only if, KUBERNETES_SECRET auth_type is used. |
Signed-off-by: shalberd <[email protected]>
Signed-off-by: shalberd <[email protected]>
Signed-off-by: shalberd <[email protected]>
Nice progress @shalberd , make sure you consider and validate the scenario where users are running Jupyter from their laptops and submitting the pipelines to hosted environments on Kubernetes-based runtimes such as kubeflow, this is an important use case/scenario. |
@lresende does Kubeflow pipelines also work with Git integration, or with direct api calls? Elyra-speaking, I mean. |
@harshad16 @lresende @caponetto @jiridanek Ok, so I built from my fork branch an Elyra wheel file and tested it with Jupyterlab 4.x and an Airflow runtime config.
runtime section, note, with COS auth type KUBERNETES_SECRET and only k8s cos secret name entered. Saving does not yield any errors when cos username and cos password are empty, as intended. |
fixes #3298
What changes were proposed in this pull request?
Elyra runtime config currently uses and stores cos-username and cos-password for communicating with S3-compatible storage verbatim.
There is a kubernetes secret option in the runtime GUI
auth_type KUBERNETES_SECRET
to specify a K8S secret to use in target runtime KFP or Airflow, but even with that setting, username and password are used and stored verbatim from within the workbench / jupyter environment itself, i.e. when the elyra extension communicated with S3.
I have changed cos-username and cos-password from being in the config and being arguments to in all places always coming from the standard envs used
AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY
I have also started modifying runtime bootstrapper.py and all the tests.
We will see ... definitely would appreciate input on this.
How was this pull request tested?
not tested yet
using the existing pytest tests
-->
Developer's Certificate of Origin 1.1