Merge pull request #1102 from NullVoxPopuli/bring-back-disableContainerStyles

Bring back disableContainerStyles

Author: wagenet

.github/workflows/ci.yml

@@ -25,6 +25,21 @@ jobs:
       - run: pnpm test:ember
         working-directory: test-app
 
+  buildtime-options-tests:
+    name: "Buildtime Options Tests"
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - uses: wyvox/action@v1
+      - run: pnpm lint
+      - run: pnpm test:ember
+        working-directory: test-app
+      - name: embroider test
+        run: node_modules/.bin/ember try:one embroider-optimized --skip-cleanup
+        working-directory: test-app
+
+
   floating-dependencies:
     name: 'Floating Dependencies'
     runs-on: ubuntu-latest
@@ -50,6 +65,7 @@ jobs:
         ember-try-scenario:
           - ember-lts-4.4
           - ember-lts-4.8
+          - ember-lts-4.12
           - ember-release
           - ember-beta
           - ember-canary

README.md

@@ -168,6 +168,37 @@ module('basic acceptance test', function(hooks) {
 });
 ```
 
+## Configuration 
+
+Configuration is optionally managed via [`@embroider/macros`](https://www.npmjs.com/package/@embroider/macros)
+
+To configure `ember-qunit`, in your `ember-cli-build.js`, add:
+```js 
+'use strict';
+
+const EmberApp = require('ember-cli/lib/broccoli/ember-app');
+
+module.exports = function (defaults) {
+  const app = new EmberApp(defaults, {
+    '@embroider/macros': {
+      setConfig: {
+        'ember-qunit': {
+          /**
+           * default: false
+           *
+           * removes the CSS for the test-container (where the app and components are rendered to)
+           */
+          disableContainerStyles: true,
+        },
+      },
+    },
+    /* ... */ 
+  });
+
+  /* ... */
+};
+```
+
 
 Contributing
 ------------------------------------------------------------------------------

addon/package.json

@@ -39,6 +39,7 @@
   },
   "dependencies": {
     "@embroider/addon-shim": "^1.0.0",
+    "@embroider/macros": "^1.11.1",
     "ember-cli-test-loader": "^3.0.0"
   },
   "devDependencies": {

addon/src/index.js

@@ -1,6 +1,11 @@
 /* globals Testem */
 import 'qunit/qunit/qunit.css';
-import './test-container-styles.css';
+
+import { macroCondition, getOwnConfig, importSync } from '@embroider/macros';
+
+if (macroCondition(!getOwnConfig()?.disableContainerStyles)) {
+  importSync('./test-container-styles.css');
+}
 
 export { default as QUnitAdapter, nonTestDoneCallback } from './adapter';
 export { loadTests } from './test-loader';