Merge pull request #1098 from NullVoxPopuli/strict-mode-deps

Strict mode deps

Author: MelSumner

.github/workflows/ci.yml

@@ -73,6 +73,8 @@ jobs:
         ts-version:
           - 4.8
           - 4.9
+          - 5.0
+          - 5.1
           - next
 
     steps:
@@ -82,4 +84,4 @@ jobs:
         working-directory: addon
       - name: test types
         run: pnpm test:types
-        working-directory: addon
+        working-directory: test-types

.npmrc

@@ -0,0 +1,8 @@
+# these settings allow us to be good stewards of the ecosystem
+# end-consumers can flip these settings in their own projects,
+# but library authors should not allow for less-than-strictest
+# behavior.
+#
+# For more information: https://pnpm.io/npmrc
+auto-install-peers=false
+resolve-peers-from-workspace-root=false

addon/package.json

@@ -34,7 +34,6 @@
     "lint:js": "eslint . --cache",
     "lint:js:fix": "eslint . --fix",
     "start": "rollup --config --watch",
-    "test:types": "tsc --noEmit --project types",
     "prepack": "rollup --config"
   },
   "dependencies": {
@@ -52,8 +51,6 @@
     "@types/qunit": "^2.19.4",
     "@types/rsvp": "^4.0.4",
     "concurrently": "^8.0.1",
-    "ember-cli-htmlbars": "^6.2.0",
-    "ember-resolver": "^10.1.0",
     "ember-source": "^4.10.0",
     "eslint": "^8.42.0",
     "eslint-config-prettier": "^8.6.0",

addon/types/tsconfig.json

@@ -13,5 +13,12 @@
   "volta": {
     "node": "18.16.0",
     "pnpm": "8.6.2"
+  },
+  "pnpm": {
+    "peerDependencyRules": {
+      "ignoreMissing": [
+        "webpack"
+      ]
+    }
   }
 }