Skip to content

Commit 3894660

Browse files
committed
Fix SCSS error and frontend linter
Last commit bumped the javascript SCSS dependency and now //deep is not allowed in SCSS anymore. The recommended way is the ::v-deep pseudo-element. The change in the vue component fixes the issue, but the linter complains. So we need to change the linter rule as well. https://phabricator.endlessm.com/T31931
1 parent ab74213 commit 3894660

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.stylelintrc.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -1 +1,9 @@
1-
module.exports = require('kolibri-tools/.stylelintrc');
1+
const Config = require('kolibri-tools/.stylelintrc');
2+
Config.rules['selector-pseudo-element-no-unknown'] = [
3+
true,
4+
{
5+
ignorePseudoElements: ['v-deep'],
6+
},
7+
];
8+
9+
module.exports = Config;

kolibri_explore_plugin/assets/src/views/ChannelCard.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
right: $margin;
165165
}
166166
167-
/deep/.card-thumbnail-wrapper {
167+
::v-deep.card-thumbnail-wrapper {
168168
max-width: 100%;
169169
}
170170

0 commit comments

Comments
 (0)