Merge pull request #820 from endlessm/ci-nodeenv

ci: Use setup-node to cache node.js environment in CI

Author: dbnicholson

.github/workflows/bump2release.yml

@@ -41,6 +41,12 @@ jobs:
         with:
           python-version: 3.9
 
+      - name: Set up Node
+        uses: actions/setup-node@v3
+        with:
+          # Should be same version as in scripts/bootstrap.sh
+          node-version: '16.14.0'
+
       - name: Install latest pipenv
         run: |
           python -m pip install --upgrade pipenv wheel

.github/workflows/lint.yml

@@ -15,6 +15,12 @@ jobs:
       with:
         python-version: 3.9
 
+    - name: Set up Node
+      uses: actions/setup-node@v3
+      with:
+        # Should be same version as in scripts/bootstrap.sh
+        node-version: '16.14.0'
+
     - name: Install latest pipenv
       run: |
         python -m pip install --upgrade pipenv wheel

.github/workflows/main.yml

@@ -37,6 +37,12 @@ jobs:
         run: |
           sudo apt install -y gettext
 
+      - name: Set up Node
+        uses: actions/setup-node@v3
+        with:
+          # Should be same version as in scripts/bootstrap.sh
+          node-version: '16.14.0'
+
       - name: Install latest pipenv
         run: |
           python -m pip install --upgrade pipenv wheel
@@ -99,6 +105,12 @@ jobs:
         run: |
           sudo apt install -y gettext
 
+      - name: Set up Node
+        uses: actions/setup-node@v3
+        with:
+          # Should be same version as in scripts/bootstrap.sh
+          node-version: '16.14.0'
+
       - name: Install latest pipenv
         run: |
           python -m pip install --upgrade pipenv wheel

.github/workflows/node.yml

@@ -20,6 +20,12 @@ jobs:
       run: |
         sudo apt install -y gettext
 
+    - name: Set up Node
+      uses: actions/setup-node@v3
+      with:
+        # Should be same version as in scripts/bootstrap.sh
+        node-version: '16.14.0'
+
     - id: cache-pipenv
       uses: actions/cache@v1
       with:

scripts/bootstrap.sh

@@ -1,16 +1,22 @@
-#!/bin/bash -e
+#!/bin/bash
 #
 # Setup Project
 
+set -e
+
 # Argument parsing
 pipenv_install_args=()
+skip_nodeenv=false
 
 while :; do
   case $1 in
     --ci)
       # Prevent the Pipfile.lock from being updated automatically. Just use
       # the pinned dependencies.
       pipenv_install_args+=( "--ignore-pipfile" )
+      # And assume that node has already been set up, as the CI system can
+      # cache that.
+      skip_nodeenv=true
       ;;
     -h|-\?|--help|-?*)
       echo "Usage: bootstrap.sh [--ci]" >&2
@@ -25,6 +31,6 @@ done
 
 # Install things
 pipenv install --dev --deploy "${pipenv_install_args[@]}"
-pipenv run nodeenv -p --node=16.14.0
+$skip_nodeenv || pipenv run nodeenv -p --node=16.14.0
 pipenv run npm install -g [email protected]
 pipenv run yarn install --ignore-engines