Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from ratelimit.proto to rls.proto in data-plane-api #14

Closed
junr03 opened this issue May 31, 2017 · 2 comments
Closed

Move from ratelimit.proto to rls.proto in data-plane-api #14

junr03 opened this issue May 31, 2017 · 2 comments
Assignees

Comments

@junr03
Copy link
Member

junr03 commented May 31, 2017

https://github.com/envoyproxy/data-plane-api/blob/master/api/rls.proto

@junr03 junr03 self-assigned this May 31, 2017
@junr03 junr03 changed the title Move from ratelimit.proto to rlds.proto in envoy-api Move from ratelimit.proto to rds.proto in envoy-api Aug 31, 2017
@junr03 junr03 changed the title Move from ratelimit.proto to rds.proto in envoy-api Move from ratelimit.proto to rds.proto in data-plane-api Dec 4, 2017
@jsedgwick
Copy link

jsedgwick commented Feb 16, 2018

@junr03 description seems wacky, do you mean that we want to migrate ratelimit's proto dependency from

https://github.com/lyft/ratelimit/blob/master/proto/ratelimit/ratelimit.proto

to

https://github.com/envoyproxy/data-plane-api/blob/master/envoy/service/ratelimit/v2/rls.proto

?

And what about envoy's dep -
https://github.com/envoyproxy/envoy/blob/master/source/common/ratelimit/ratelimit.proto?

Seems like a lot of copypasta...

I can work on this once the intention is clarified.

@junr03 junr03 assigned jsedgwick and unassigned junr03 Feb 16, 2018
@junr03 junr03 assigned junr03 and unassigned jsedgwick Apr 4, 2018
@junr03
Copy link
Member Author

junr03 commented Apr 4, 2018

Assigning back to myself. Will do as part of Lyft's work on this area for Q2

@junr03 junr03 changed the title Move from ratelimit.proto to rds.proto in data-plane-api Move from ratelimit.proto to rls.proto in data-plane-api Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants