Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples need a build step #66

Closed
ostrgard opened this issue Aug 12, 2015 · 3 comments
Closed

Examples need a build step #66

ostrgard opened this issue Aug 12, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@ostrgard
Copy link

Both examples is missing a client.min.js build and express handling of requests to this file.

... or am I missing somthing?

@ericclemmons
Copy link
Owner

@ostrgard Whoops, I'll put something in their READMEs.

Do npm run watch for now. With the refactor I forgot to update their docs & put in a proper build step for a plain npm start.

https://github.com/ericclemmons/react-resolver/blob/master/examples/react-v0.13/package.json#L7

@ericclemmons ericclemmons self-assigned this Aug 12, 2015
@ericclemmons ericclemmons added this to the v2 milestone Aug 12, 2015
@ostrgard
Copy link
Author

Alright! I'm having an issue with react-router and react-resolver that I can't test in your examples without the build step. I'm writing separate issue on that right now though.

Thank you for the quick response!

@ericclemmons ericclemmons changed the title Examples not working Examples need a build step Aug 13, 2015
@ostrgard ostrgard mentioned this issue Aug 13, 2015
@ericclemmons
Copy link
Owner

With v2.0.3 these examples have a README with steps:

https://github.com/ericclemmons/react-resolver/tree/master/examples/react-v0.13

Basically, npm start for dev, and NODE_ENV=production npm start for the build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants