Fix long Ticker period conversion: cast ms to uint64_t when calculating us (#3175)

full-stack-ex · me-no-dev · commit 2a7e50997893 · 2019-09-05T10:34:47.000+03:00
* Fix long Ticker period conversion

* Simplify long Ticker period conversion fix by using 1000ULL
diff --git a/libraries/Ticker/src/Ticker.cpp b/libraries/Ticker/src/Ticker.cpp
@@ -43,9 +43,9 @@ void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t
   }
   esp_timer_create(&_timerConfig, &_timer);
   if (repeat) {
-    esp_timer_start_periodic(_timer, milliseconds * 1000);
+    esp_timer_start_periodic(_timer, milliseconds * 1000ULL);
   } else {
-    esp_timer_start_once(_timer, milliseconds * 1000);
+    esp_timer_start_once(_timer, milliseconds * 1000ULL);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,9 @@ void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t`
`43`	`43`	`}`
`44`	`44`	`esp_timer_create(&_timerConfig, &_timer);`
`45`	`45`	`if (repeat) {`
`46`		`- esp_timer_start_periodic(_timer, milliseconds * 1000);`
	`46`	`+ esp_timer_start_periodic(_timer, milliseconds * 1000ULL);`
`47`	`47`	`} else {`
`48`		`- esp_timer_start_once(_timer, milliseconds * 1000);`
	`48`	`+ esp_timer_start_once(_timer, milliseconds * 1000ULL);`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`