fix(ota): Make sure that ArduinoOTA.end() is called in the destructor (#10932)

me-no-dev · web-flow · commit 6a1127625c1e · 2025-02-04T13:22:20.000+02:00
diff --git a/libraries/ArduinoOTA/src/ArduinoOTA.cpp b/libraries/ArduinoOTA/src/ArduinoOTA.cpp
@@ -29,7 +29,7 @@ ArduinoOTAClass::ArduinoOTAClass()
     _start_callback(NULL), _end_callback(NULL), _error_callback(NULL), _progress_callback(NULL) {}
 
 ArduinoOTAClass::~ArduinoOTAClass() {
-  _udp_ota.stop();
+  end();
 }
 
 ArduinoOTAClass &ArduinoOTAClass::onStart(THandlerFunction fn) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ ArduinoOTAClass::ArduinoOTAClass()`
`29`	`29`	`_start_callback(NULL), _end_callback(NULL), _error_callback(NULL), _progress_callback(NULL) {}`
`30`	`30`
`31`	`31`	`ArduinoOTAClass::~ArduinoOTAClass() {`
`32`		`- _udp_ota.stop();`
	`32`	`+ end();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`ArduinoOTAClass &ArduinoOTAClass::onStart(THandlerFunction fn) {`