Skip to content

Commit a55abe0

Browse files
committed
fix(variant): Fixed review comments for SPI and I2C Pins
1 parent 034d303 commit a55abe0

File tree

3 files changed

+23
-21
lines changed

3 files changed

+23
-21
lines changed

variants/BharatPi-A7672S-4G/pins_arduino.h

+9
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,13 @@ static const uint8_t RX = 3;
2020
static const uint8_t TX_4G = 17;
2121
static const uint8_t RX_4G = 16;
2222

23+
static const uint8_t SDA = 21;
24+
static const uint8_t SCL = 22;
25+
26+
static const uint8_t SS = 5;
27+
static const uint8_t MOSI = 23;
28+
static const uint8_t MISO = 19;
29+
static const uint8_t SCK = 18;
30+
31+
2332
#endif /* Pins_Arduino_h */

variants/BharatPi-LoRa/pins_arduino.h

+8
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,12 @@ static const uint8_t SS = 4;
2424
static const uint8_t RST = 14;
2525
static const uint8_t DIO0 = 2;
2626

27+
static const uint8_t SDA = 21;
28+
static const uint8_t SCL = 22;
29+
30+
static const uint8_t SS = -1;
31+
static const uint8_t MOSI = -1;
32+
static const uint8_t MISO = -1;
33+
static const uint8_t SCK = -1;
34+
2735
#endif /* Pins_Arduino_h */

variants/BharatPi-Node-Wifi/pins_arduino.h

+6-21
Original file line numberDiff line numberDiff line change
@@ -23,29 +23,14 @@ static const uint8_t RX = 3;
2323

2424
static const uint8_t TX2 = 17;
2525
static const uint8_t RX2 = 16;
26-
#endif /* Pins_Arduino_h */#ifndef Pins_Arduino_h
27-
#define Pins_Arduino_h
28-
29-
#include <stdint.h>
30-
31-
static const uint8_t LED_BUILTIN = 2;
32-
#define BUILTIN_LED LED_BUILTIN // backward compatibility
33-
#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN
3426

35-
static const uint8_t SAFFRON_LED = 12;
36-
static const uint8_t WHITE_LED = 2;
37-
static const uint8_t GREEN_LED = 13;
27+
static const uint8_t SDA = 21;
28+
static const uint8_t SCL = 22;
3829

39-
static const uint8_t A0 = 14;
40-
static const uint8_t A1 = 13;
41-
static const uint8_t A2 = 12;
42-
static const uint8_t A3 = 4;
43-
static const uint8_t A4 = 2;
44-
static const uint8_t A5 = 0;
30+
static const uint8_t SS = 5;
31+
static const uint8_t MOSI = 23;
32+
static const uint8_t MISO = 19;
33+
static const uint8_t SCK = 18;
4534

46-
static const uint8_t TX = 1;
47-
static const uint8_t RX = 3;
4835

49-
static const uint8_t TX2 = 17;
50-
static const uint8_t RX2 = 16;
5136
#endif /* Pins_Arduino_h */

0 commit comments

Comments
 (0)