You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am preparing a PR to contribute middleware support (aka Expressif) to WebServer, plus some examples and middleware implementations (cors, security, logging).
I didn't find any guidelines explaining the process to compile our changes and test the examples we write on a real board before submitting the PR.
Right now, I work around that by adding some platformio.ini files and using PIO to build the examples, but this is quite a hack.
What contributors should do to locally test and run the examples we write against the modifications we did ?
Thanks :-)
I have checked existing issues, online documentation and the Troubleshooting Guide
I confirm I have checked existing issues, online documentation and Troubleshooting guide.
The text was updated successfully, but these errors were encountered:
@mathieucarbou Thx, for bringing this up. After the big refactoring of the GH Actions (btw. great work imho) i do not manage to test my changes anymore before opening a PR ;-)
@mathieucarbou Thx, for bringing this up. After the big refactoring of the GH Actions (btw. great work imho) i do not manage to test my changes anymore before opening a PR ;-)
I've tried running github/scripts/on-push.sh locally, it succeeded, which proves it didn't consider my changes... 🤣
So right now I am "working" with this simple pio file put inside libraries/WebServer:
Description
Hello,
I am preparing a PR to contribute middleware support (aka Expressif) to WebServer, plus some examples and middleware implementations (cors, security, logging).
I didn't find any guidelines explaining the process to compile our changes and test the examples we write on a real board before submitting the PR.
Right now, I work around that by adding some platformio.ini files and using PIO to build the examples, but this is quite a hack.
What contributors should do to locally test and run the examples we write against the modifications we did ?
Thanks :-)
I have checked existing issues, online documentation and the Troubleshooting Guide
The text was updated successfully, but these errors were encountered: