From c41c8f09595f27eb19a1e06c29ad69c6ead67521 Mon Sep 17 00:00:00 2001 From: stefan-sherwood Date: Mon, 6 Jan 2025 17:27:48 -0500 Subject: [PATCH 1/4] Add method for querying service name --- libraries/ESPmDNS/src/ESPmDNS.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries/ESPmDNS/src/ESPmDNS.h b/libraries/ESPmDNS/src/ESPmDNS.h index 0336f476efe..1fb90bbf454 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.h +++ b/libraries/ESPmDNS/src/ESPmDNS.h @@ -110,6 +110,7 @@ class MDNSResponder { } String hostname(int idx); + String instanceName(int idx); IPAddress address(int idx); IPAddress addressV6(int idx); uint16_t port(int idx); From e6670a4b15d005d7642c7f8f683e4f9d334bf693 Mon Sep 17 00:00:00 2001 From: stefan-sherwood Date: Mon, 6 Jan 2025 17:29:18 -0500 Subject: [PATCH 2/4] Added implementation for getting service name --- libraries/ESPmDNS/src/ESPmDNS.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libraries/ESPmDNS/src/ESPmDNS.cpp b/libraries/ESPmDNS/src/ESPmDNS.cpp index 4c15ed3a5dd..38dddbdac48 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.cpp +++ b/libraries/ESPmDNS/src/ESPmDNS.cpp @@ -299,6 +299,16 @@ String MDNSResponder::hostname(int idx) { return String(result->hostname); } +String MDNSResponder::instanceName(int idx) { + mdns_result_t *result = _getResult(idx); + if (!result) { + log_e("Result %d not found", idx); + return String(); + } + return String(result->instance_name); +} + + IPAddress MDNSResponder::address(int idx) { mdns_result_t *result = _getResult(idx); if (!result) { From 33988ca63ccb5e17b4820f0f995384b6b140dd75 Mon Sep 17 00:00:00 2001 From: stefan-sherwood Date: Mon, 6 Jan 2025 17:42:52 -0500 Subject: [PATCH 3/4] Update mDNS-SD_Extended example to include service name --- .../ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino b/libraries/ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino index d2e48c0580c..e630d668cea 100644 --- a/libraries/ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino +++ b/libraries/ESPmDNS/examples/mDNS-SD_Extended/mDNS-SD_Extended.ino @@ -68,6 +68,8 @@ void browseService(const char *service, const char *proto) { Serial.print(" "); Serial.print(i + 1); Serial.print(": "); + Serial.print(MDNS.instanceName(i)); + Serial.print(" - "); Serial.print(MDNS.hostname(i)); Serial.print(" ("); Serial.print(MDNS.address(i)); From 25658e9455dff1cfabe184a09f4a1d25d2947b70 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci-lite[bot]" <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Date: Tue, 7 Jan 2025 16:03:01 +0000 Subject: [PATCH 4/4] ci(pre-commit): Apply automatic fixes --- libraries/ESPmDNS/src/ESPmDNS.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/ESPmDNS/src/ESPmDNS.cpp b/libraries/ESPmDNS/src/ESPmDNS.cpp index 38dddbdac48..5d422513bbd 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.cpp +++ b/libraries/ESPmDNS/src/ESPmDNS.cpp @@ -308,7 +308,6 @@ String MDNSResponder::instanceName(int idx) { return String(result->instance_name); } - IPAddress MDNSResponder::address(int idx) { mdns_result_t *result = _getResult(idx); if (!result) {