From bed762c2915e105fcd9245ab5141cb2c0b92e816 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Proch=C3=A1zka?= <90197375+P-R-O-C-H-Y@users.noreply.github.com> Date: Thu, 9 Jan 2025 13:57:52 +0100 Subject: [PATCH 1/2] fix(i2s): Check if pin is used before clearing bus --- libraries/ESP_I2S/src/ESP_I2S.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libraries/ESP_I2S/src/ESP_I2S.cpp b/libraries/ESP_I2S/src/ESP_I2S.cpp index 0ac1e176dc8..77fa6177361 100644 --- a/libraries/ESP_I2S/src/ESP_I2S.cpp +++ b/libraries/ESP_I2S/src/ESP_I2S.cpp @@ -719,9 +719,15 @@ bool I2SClass::end() { #if SOC_I2S_SUPPORTS_TDM case I2S_MODE_TDM: #endif - perimanClearPinBus(_mclk); - perimanClearPinBus(_bclk); - perimanClearPinBus(_ws); + if(_mclk >= 0) { + perimanClearPinBus(_mclk); + } + if(_bclk >= 0) { + perimanClearPinBus(_bclk); + } + if(_ws >= 0) { + perimanClearPinBus(_ws); + } if (_dout >= 0) { perimanClearPinBus(_dout); } From 7252e81dd8b6a3297c400ca949c386eab9c8b261 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci-lite[bot]" <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Date: Fri, 10 Jan 2025 11:56:40 +0000 Subject: [PATCH 2/2] ci(pre-commit): Apply automatic fixes --- libraries/ESP_I2S/src/ESP_I2S.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/ESP_I2S/src/ESP_I2S.cpp b/libraries/ESP_I2S/src/ESP_I2S.cpp index 77fa6177361..d0ceb0c4b4c 100644 --- a/libraries/ESP_I2S/src/ESP_I2S.cpp +++ b/libraries/ESP_I2S/src/ESP_I2S.cpp @@ -719,13 +719,13 @@ bool I2SClass::end() { #if SOC_I2S_SUPPORTS_TDM case I2S_MODE_TDM: #endif - if(_mclk >= 0) { + if (_mclk >= 0) { perimanClearPinBus(_mclk); } - if(_bclk >= 0) { + if (_bclk >= 0) { perimanClearPinBus(_bclk); } - if(_ws >= 0) { + if (_ws >= 0) { perimanClearPinBus(_ws); } if (_dout >= 0) {