Merge pull request #10534 from johncming/close_reader

xiang90 · web-flow · commit dc5041615758 · 2019-03-12T08:25:32.000-07:00
close http request body after read it.
diff --git a/contrib/raftexample/httpapi.go b/contrib/raftexample/httpapi.go
@@ -31,6 +31,7 @@ type httpKVAPI struct {
 
 func (h *httpKVAPI) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	key := r.RequestURI
+	defer r.Body.Close()
 	switch {
 	case r.Method == "PUT":
 		v, err := ioutil.ReadAll(r.Body)
diff --git a/lease/leasehttp/http.go b/lease/leasehttp/http.go
@@ -52,6 +52,7 @@ func (h *leaseHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	defer r.Body.Close()
 	b, err := ioutil.ReadAll(r.Body)
 	if err != nil {
 		http.Error(w, "error reading body", http.StatusBadRequest)

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ func (h leaseHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {`
`52`	`52`	`return`
`53`	`53`	`}`
`54`	`54`
	`55`	`+ defer r.Body.Close()`
`55`	`56`	`b, err := ioutil.ReadAll(r.Body)`
`56`	`57`	`if err != nil {`
`57`	`58`	`http.Error(w, "error reading body", http.StatusBadRequest)`