Add golangci-lint workflow

Author: skryukov

.github/workflows/lint.yml

@@ -0,0 +1,17 @@
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+name: Lint
+jobs:
+  golangci:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          args: '-E gofmt'

.golangci.yml

@@ -0,0 +1,39 @@
+linters-settings:
+  govet:
+    check-shadowing: true
+  misspell:
+    locale: US
+
+linters:
+  disable-all: true
+  enable:
+   - bodyclose
+   - deadcode
+   - depguard
+   - dogsled
+   - dupl
+   - errcheck
+   - exportloopref
+   - exhaustive
+   - goconst
+   - gocyclo
+   - gofmt
+   - goimports
+   - golint
+   - goprintffuncname
+   - gosimple
+   - govet
+   - ineffassign
+   - misspell
+   - nakedret
+   - noctx
+   - nolintlint
+   - rowserrcheck
+   - staticcheck
+   - structcheck
+   - typecheck
+   - unconvert
+   - unparam
+   - unused
+   - varcheck
+   - whitespace

cmd/cmd_test.go

@@ -88,7 +88,7 @@ func TestAddCmdExecutor(t *testing.T) {
 		actualFiles = append(actualFiles, f.Name())
 	}
 
-	assert.Equal(t, expectedDirs, actualDirs, "Haven`t renamed file with .old extension")
+	assert.Equal(t, expectedFiles, actualFiles, "Haven`t renamed file with .old extension")
 }
 
 func TestRunCmdExecutor(t *testing.T) {
@@ -101,7 +101,7 @@ pre-commit:
       run: echo 'test passed'
 `)
 	viper.SetConfigType("yaml")
-	viper.ReadConfig(bytes.NewBuffer(yamlExample))
+	_ = viper.ReadConfig(bytes.NewBuffer(yamlExample))
 
 	var buf bytes.Buffer
 	log.SetOutput(&buf)
@@ -124,29 +124,28 @@ func TestExtendsProperty(t *testing.T) {
 	var expectedPathsString = []string{"c3.yml"}
 	viper.SetConfigType("yaml")
 
-	viper.ReadConfig(bytes.NewBuffer([]byte("")))
+	_ = viper.ReadConfig(bytes.NewBuffer([]byte("")))
 	assert.False(t, isConfigExtends(), "Should not detect extends property")
 
-	viper.ReadConfig(bytes.NewBuffer(yamlExampleString))
+	_ = viper.ReadConfig(bytes.NewBuffer(yamlExampleString))
 	paths := getExtendsPath()
 
 	assert.True(t, isConfigExtends(), "Should detect extends property")
 	assert.Equal(t, paths, expectedPathsString, "Extends path does not match for string value")
 
-	viper.ReadConfig(bytes.NewBuffer(yamlExampleArray))
+	_ = viper.ReadConfig(bytes.NewBuffer(yamlExampleArray))
 	paths = getExtendsPath()
 	assert.Equal(t, paths, expectedPathsArray, "Extends path does not match for array value")
-
 }
 
 func presetConfig(fs afero.Fs) {
 	viper.SetDefault(configSourceDirKey, ".lefthook")
 
 	AddConfigYaml(fs)
 
-	fs.Mkdir(filepath.Join(getRootPath(), ".lefthook/commit-msg"), defaultFilePermission)
-	fs.Mkdir(filepath.Join(getRootPath(), ".lefthook/pre-commit"), defaultFilePermission)
+	_ = fs.Mkdir(filepath.Join(getRootPath(), ".lefthook/commit-msg"), defaultFilePermission)
+	_ = fs.Mkdir(filepath.Join(getRootPath(), ".lefthook/pre-commit"), defaultFilePermission)
 
 	setGitHooksPath(".git/hooks")
-	fs.MkdirAll(getGitHooksPath(), defaultFilePermission)
+	_ = fs.MkdirAll(getGitHooksPath(), defaultFilePermission)
 }

cmd/install.go

@@ -121,7 +121,7 @@ func getConfigLocalYamlPattern() string {
 func hasValidConfigFile(fs afero.Fs) bool {
 	matches, err := afero.Glob(fs, getConfigYamlPattern())
 	if err != nil {
-		log.Println("Error occured for search config file: ", err.Error())
+		log.Println("Error occurred for search config file: ", err.Error())
 	}
 	for _, match := range matches {
 		extension := filepath.Ext(match)

cmd/root.go

@@ -90,23 +90,23 @@ func initAurora() {
 func initConfig() {
 	log.SetFlags(0)
 
-	setRootPath(rootExecutionRelPath)
+	setRootPath()
 	setGitHooksPath(getHooksPathFromGitConfig())
 
 	// store original config before merge
 	originConfig = viper.New()
 	originConfig.SetConfigName(configFileName)
 	originConfig.AddConfigPath(rootExecutionRelPath)
-	originConfig.ReadInConfig()
+	_ = originConfig.ReadInConfig()
 
 	viper.SetConfigName(configFileName)
 	viper.AddConfigPath(rootExecutionRelPath)
 	viper.SetDefault(configSourceDirKey, ".lefthook")
 	viper.SetDefault(configSourceDirLocalKey, ".lefthook-local")
-	viper.ReadInConfig()
+	_ = viper.ReadInConfig()
 
 	viper.SetConfigName(configLocalFileName)
-	viper.MergeInConfig()
+	_ = viper.MergeInConfig()
 
 	if isConfigExtends() {
 		for _, path := range getExtendsPath() {
@@ -127,7 +127,7 @@ func getRootPath() string {
 	return rootPath
 }
 
-func setRootPath(path string) {
+func setRootPath() {
 	// get absolute path to .git dir (project root)
 	cmd := exec.Command("git", "rev-parse", "--show-toplevel")
 

cmd/run.go

@@ -199,13 +199,13 @@ func executeCommand(hooksGroup, commandName string, wg *sync.WaitGroup, gitArgs
 
 	VerbosePrint("Files after filters: \n", files)
 
-	files_esc := []string{}
+	filesEsc := []string{}
 	for _, fileName := range files {
 		if len(fileName) > 0 {
-			files_esc = append(files_esc, shellescape.Quote(fileName))
+			filesEsc = append(filesEsc, shellescape.Quote(fileName))
 		}
 	}
-	files = files_esc
+	files = filesEsc
 	VerbosePrint("Files after escaping: \n", files)
 
 	runner = strings.Replace(runner, pushFiles, strings.Join(files, " "), -1)

cmd/run_command.go

@@ -32,9 +32,9 @@ func RunPlainCommand(command *exec.Cmd) (*bytes.Buffer, WaitFunc, error) {
 	commandOutput := bytes.NewBuffer(make([]byte, 0))
 	_, _ = io.Copy(commandOutput, ptyOut)
 	waitFunc := func() error {
-		err := command.Wait()
+		wErr := command.Wait()
 		_ = ptyOut.Close()
-		return err
+		return wErr
 	}
-	return 	commandOutput, waitFunc, err
+	return commandOutput, waitFunc, err
 }

pkg/context/context.go

@@ -65,9 +65,8 @@ func isFile(path string) (bool, error) {
 	if err != nil {
 		if os.IsNotExist(err) {
 			return false, nil
-		} else {
-			return false, err
 		}
+		return false, err
 	}
 
 	return !stat.IsDir(), nil