Skip to content

Commit 747f5a1

Browse files
committed
tests: remove deep-equal dependency
1 parent ff3a789 commit 747f5a1

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

Diff for: package.json

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
"cookie-signature": "1.0.6"
1818
},
1919
"devDependencies": {
20-
"deep-equal": "1.0.1",
2120
"eslint": "6.8.0",
2221
"eslint-config-standard": "14.1.0",
2322
"eslint-plugin-import": "2.20.1",

Diff for: test/cookieParser.js

+12-13
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11

22
var assert = require('assert')
33
var cookieParser = require('..')
4-
var deepEqual = require('deep-equal')
54
var http = require('http')
65
var request = require('supertest')
76
var signature = require('cookie-signature')
@@ -155,7 +154,7 @@ describe('cookieParser.JSONCookie(str)', function () {
155154
})
156155

157156
it('should return object for JSON cookie string', function () {
158-
deepEqual(cookieParser.JSONCookie('j:{"foo":"bar"}'), { foo: 'bar' })
157+
assert.deepEqual(cookieParser.JSONCookie('j:{"foo":"bar"}'), { foo: 'bar' })
159158
})
160159

161160
it('should return undefined on invalid JSON', function () {
@@ -213,18 +212,18 @@ describe('cookieParser.signedCookie(str, secret)', function () {
213212

214213
describe('cookieParser.signedCookies(obj, secret)', function () {
215214
it('should ignore non-signed strings', function () {
216-
deepEqual(cookieParser.signedCookies({}, 'keyboard cat'), {})
217-
deepEqual(cookieParser.signedCookies({ foo: 'bar' }, 'keyboard cat'), {})
215+
assert.deepEqual(cookieParser.signedCookies({}, 'keyboard cat'), {})
216+
assert.deepEqual(cookieParser.signedCookies({ foo: 'bar' }, 'keyboard cat'), {})
218217
})
219218

220219
it('should include tampered strings as false', function () {
221-
deepEqual(cookieParser.signedCookies({ foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
220+
assert.deepEqual(cookieParser.signedCookies({ foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
222221
foo: false
223222
})
224223
})
225224

226225
it('should include unsigned strings', function () {
227-
deepEqual(cookieParser.signedCookies({ foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
226+
assert.deepEqual(cookieParser.signedCookies({ foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE' }, 'keyboard cat'), {
228227
foo: 'foobar'
229228
})
230229
})
@@ -234,17 +233,17 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
234233
foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
235234
}
236235

237-
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
238-
deepEqual(obj, {})
236+
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
237+
assert.deepEqual(obj, {})
239238
})
240239

241240
it('should remove tampered strings from original object', function () {
242241
var obj = {
243242
foo: 's:foobaz.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
244243
}
245244

246-
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: false })
247-
deepEqual(obj, {})
245+
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: false })
246+
assert.deepEqual(obj, {})
248247
})
249248

250249
it('should leave unsigned string in original object', function () {
@@ -253,8 +252,8 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
253252
foo: 's:foobar.N5r0C3M8W+IPpzyAJaIddMWbTGfDSO+bfKlZErJ+MeE'
254253
}
255254

256-
deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
257-
deepEqual(obj, { fizz: 'buzz' })
255+
assert.deepEqual(cookieParser.signedCookies(obj, 'keyboard cat'), { foo: 'foobar' })
256+
assert.deepEqual(obj, { fizz: 'buzz' })
258257
})
259258

260259
describe('when secret is an array', function () {
@@ -264,7 +263,7 @@ describe('cookieParser.signedCookies(obj, secret)', function () {
264263
fizz: 's:foobar.JTCAgiMWsnuZpN3mrYnEUjXlGxmDi4POCBnWbRxse88'
265264
}
266265

267-
deepEqual(cookieParser.signedCookies(obj, ['keyboard cat', 'nyan cat']), {
266+
assert.deepEqual(cookieParser.signedCookies(obj, ['keyboard cat', 'nyan cat']), {
268267
buzz: 'foobar',
269268
fizz: 'foobar'
270269
})

0 commit comments

Comments
 (0)