Skip to content

Commit 0a48e18

Browse files
committed
Revert "Improve error message for null/undefined to res.status"
fixes #3968
1 parent eed05a1 commit 0a48e18

File tree

3 files changed

+5
-36
lines changed

3 files changed

+5
-36
lines changed

History.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
unreleased
2+
==========
3+
4+
* Revert "Improve error message for `null`/`undefined` to `res.status`"
5+
16
4.17.0 / 2019-05-16
27
===================
38

lib/response.js

-4
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,6 @@ var charsetRegExp = /;\s*charset\s*=/;
6464
*/
6565

6666
res.status = function status(code) {
67-
if (code === undefined || code === null) {
68-
throw new TypeError('code argument is required to res.status')
69-
}
70-
7167
this.statusCode = code;
7268
return this;
7369
};

test/res.status.js

-32
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,5 @@ describe('res', function(){
1616
.expect('Created')
1717
.expect(201, done);
1818
})
19-
20-
describe('when code is undefined', function () {
21-
it('should throw a TypeError', function (done) {
22-
var app = express()
23-
24-
app.use(function (req, res) {
25-
res.status(undefined).send('OK')
26-
})
27-
28-
request(app)
29-
.get('/')
30-
.expect(500)
31-
.expect(/TypeError: code argument is required to res.status/)
32-
.end(done)
33-
})
34-
})
35-
36-
describe('when code is null', function () {
37-
it('should throw a TypeError', function (done) {
38-
var app = express()
39-
40-
app.use(function (req, res) {
41-
res.status(null).send('OK')
42-
})
43-
44-
request(app)
45-
.get('/')
46-
.expect(500)
47-
.expect(/TypeError: code argument is required to res.status/)
48-
.end(done)
49-
})
50-
})
5119
})
5220
})

0 commit comments

Comments
 (0)