Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 4111359

Browse files
slagiewkawesleytodd
authored andcommittedJan 10, 2025··
fix(refactor): prefix built-in node module imports
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0 [^1][^2]). It's functionally irrelevant: 1. It's not required for CJS nor ESM (with a few exceptions [^3]) 2. It has no performance promises However, there are upsides to this approach: 1. It brings clear boundaries to what's a built-in and what's an external dependency 2. It reduces the risk of importing unwanted deps where a built-in is expected 3. It's slightly more interoperable with other JS runtimes that provide node compatibility[^4], albeit only during development. Once imported from npm, built-ins are assumed. [^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules [^2]:nodejs/node#37246 [^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix [^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
1 parent 6a40af8 commit 4111359

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+442
-441
lines changed
 

‎History.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ unreleased
77
* cleanup: remove unnecessary require for global Buffer
88
* perf: use loop for acceptParams
99
* Replace `methods` dependency with standard library
10+
* refactor: prefix built-in node module imports
1011

1112
5.0.1 / 2024-10-08
1213
==========

‎examples/auth/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
var express = require('../..');
88
var hash = require('pbkdf2-password')()
9-
var path = require('path');
9+
var path = require('node:path');
1010
var session = require('express-session');
1111

1212
var app = module.exports = express();

0 commit comments

Comments
 (0)
Please sign in to comment.