Remove unnecessary flake8 B950 suppressions

Reviewed By: mzlee

Differential Revision: D22091444

fbshipit-source-id: 3b1e3d8a1f3b60d22f2ba0bcfe8b43ba789dfb77

Author: zertosh

commands/FBAccessibilityCommands.py

@@ -95,15 +95,15 @@ def accessibilityGrepHierarchy(self, view, needle):
             # We call private method that gives back all visible accessibility children
             # for view iOS 10 and higher
             if fb.evaluateBooleanExpression(
-                "[UIView respondsToSelector:@selector(_accessibilityElementsAndContainersDescendingFromViews:options:sorted:)]"  # noqa B950
+                "[UIView respondsToSelector:@selector(_accessibilityElementsAndContainersDescendingFromViews:options:sorted:)]"
             ):
                 accessibilityElements = fb.evaluateObjectExpression(
-                    "[UIView _accessibilityElementsAndContainersDescendingFromViews:@[(id)%s] options:0 sorted:NO]"  # noqa B950
+                    "[UIView _accessibilityElementsAndContainersDescendingFromViews:@[(id)%s] options:0 sorted:NO]"
                     % view
                 )
             else:
                 accessibilityElements = fb.evaluateObjectExpression(
-                    "[[[UIApplication sharedApplication] keyWindow] _accessibilityElementsInContainer:0 topLevel:%s includeKB:0]"  # noqa B950
+                    "[[[UIApplication sharedApplication] keyWindow] _accessibilityElementsInContainer:0 topLevel:%s includeKB:0]"
                     % view
                 )
             accessibilityElementsCount = fb.evaluateIntegerExpression(
@@ -156,7 +156,7 @@ def isRunningInSimulator():
 def forceStartAccessibilityServer():
     # We try to start accessibility server only if we don't have needed method active
     if not fb.evaluateBooleanExpression(
-        "[UIView instancesRespondToSelector:@selector(_accessibilityElementsInContainer:)]"  # noqa B950
+        "[UIView instancesRespondToSelector:@selector(_accessibilityElementsInContainer:)]"
     ):
         # Starting accessibility server is different for simulator and device
         if isRunningInSimulator():
@@ -165,7 +165,7 @@ def forceStartAccessibilityServer():
             )
         else:
             fb.evaluateEffect(
-                "[[[UIApplication sharedApplication] _accessibilityBundlePrincipalClass] _accessibilityStartServer]"  # noqa B950
+                "[[[UIApplication sharedApplication] _accessibilityBundlePrincipalClass] _accessibilityStartServer]"
             )
 
 
@@ -198,7 +198,7 @@ def accessibilityElements(view):
         return fb.evaluateExpression("(id)[%s _accessibleSubviews]" % (view), False)
     else:
         return fb.evaluateObjectExpression(
-            "[[[UIApplication sharedApplication] keyWindow] _accessibilityElementsInContainer:0 topLevel:%s includeKB:0]"  # noqa B950
+            "[[[UIApplication sharedApplication] keyWindow] _accessibilityElementsInContainer:0 topLevel:%s includeKB:0]"
             % view
         )
 

commands/FBAutoLayoutCommands.py

@@ -42,7 +42,7 @@ def args(self):
     def run(self, arguments, options):
         view = fb.evaluateInputExpression(arguments[0])
         opt = fb.evaluateBooleanExpression(
-            "[UIView instancesRespondToSelector:@selector(_autolayoutTraceRecursively:)]"  # noqa B950
+            "[UIView instancesRespondToSelector:@selector(_autolayoutTraceRecursively:)]"
         )
         traceCall = "_autolayoutTraceRecursively:1" if opt else "_autolayoutTrace"
         print(fb.describeObject("[{} {}]".format(view, traceCall)))

commands/FBComponentCommands.py

@@ -70,15 +70,15 @@ def options(self):
                 arg="upwards",
                 boolean=True,
                 default=False,
-                help="Print only the component hierarchy found on the first superview that has them, carrying the search up to its window.",  # noqa B950
+                help="Print only the component hierarchy found on the first superview that has them, carrying the search up to its window.",
             ),
             fb.FBCommandArgument(
                 short="-v",
                 long="--show-views",
                 arg="showViews",
                 type="BOOL",
                 default="YES",
-                help="Prints the component hierarchy and does not print the views if the supplied argument is 'NO'. Supply either a 'YES' or a 'NO'. The default is to show views.",  # noqa B950
+                help="Prints the component hierarchy and does not print the views if the supplied argument is 'NO'. Supply either a 'YES' or a 'NO'. The default is to show views.",
             ),
         ]
 
@@ -87,7 +87,7 @@ def args(self):
             fb.FBCommandArgument(
                 arg="aView",
                 type="UIView* or CKComponent*",
-                help="The view or component from which the search for components begins.",  # noqa B950
+                help="The view or component from which the search for components begins.",
                 default="(id)[[UIApplication sharedApplication] keyWindow]",
             )
         ]
@@ -103,7 +103,7 @@ def run(self, arguments, options):
 
         print(
             fb.describeObject(
-                "[CKComponentHierarchyDebugHelper componentHierarchyDescriptionForView:(UIView *)"  # noqa B950
+                "[CKComponentHierarchyDebugHelper componentHierarchyDescriptionForView:(UIView *)"
                 + view
                 + " searchUpwards:"
                 + upwards

commands/FBDebugCommands.py

@@ -53,7 +53,7 @@ def run(self, arguments, options):
 
         objectAddress = int(fb.evaluateObjectExpression(commandForObject), 0)
 
-        ivarOffsetCommand = '(ptrdiff_t)ivar_getOffset((void*)object_getInstanceVariable((id){}, "{}", 0))'.format(  # noqa B950
+        ivarOffsetCommand = '(ptrdiff_t)ivar_getOffset((void*)object_getInstanceVariable((id){}, "{}", 0))'.format(
             objectAddress, ivarName
         )
         ivarOffset = int(fb.evaluateExpression(ivarOffsetCommand), 0)
@@ -62,7 +62,7 @@ def run(self, arguments, options):
         # not permanent in the session like $variables.
         ivarSizeCommand = (
             "unsigned int size = 0;"
-            'char *typeEncoding = (char *)ivar_getTypeEncoding((void*)class_getInstanceVariable((Class)object_getClass((id){}), "{}"));'  # noqa B950
+            'char *typeEncoding = (char *)ivar_getTypeEncoding((void*)class_getInstanceVariable((Class)object_getClass((id){}), "{}"));'
             "(char *)NSGetSizeAndAlignment(typeEncoding, &size, 0);"
             "size"
         ).format(objectAddress, ivarName)
@@ -88,14 +88,14 @@ def name(self):
         return "binside"
 
     def description(self):
-        return "Set a breakpoint for a relative address within the framework/library that's currently running. This does the work of finding the offset for the framework/library and sliding your address accordingly."  # noqa B950
+        return "Set a breakpoint for a relative address within the framework/library that's currently running. This does the work of finding the offset for the framework/library and sliding your address accordingly."
 
     def args(self):
         return [
             fb.FBCommandArgument(
                 arg="address",
                 type="string",
-                help="Address within the currently running framework to set a breakpoint on.",  # noqa B950
+                help="Address within the currently running framework to set a breakpoint on.",
             )
         ]
 
@@ -118,14 +118,14 @@ def name(self):
         return "bmessage"
 
     def description(self):
-        return "Set a breakpoint for a selector on a class, even if the class itself doesn't override that selector. It walks the hierarchy until it finds a class that does implement the selector and sets a conditional breakpoint there."  # noqa B950
+        return "Set a breakpoint for a selector on a class, even if the class itself doesn't override that selector. It walks the hierarchy until it finds a class that does implement the selector and sets a conditional breakpoint there."
 
     def args(self):
         return [
             fb.FBCommandArgument(
                 arg="expression",
                 type="string",
-                help='Expression to set a breakpoint on, e.g. "-[MyView setFrame:]", "+[MyView awesomeClassMethod]" or "-[0xabcd1234 setFrame:]"',  # noqa B950
+                help='Expression to set a breakpoint on, e.g. "-[MyView setFrame:]", "+[MyView awesomeClassMethod]" or "-[0xabcd1234 setFrame:]"',
             )
         ]
 
@@ -155,7 +155,7 @@ def run(self, arguments, options):
         if not expressionForSelf:
             arch = objc.currentArch()
             print(
-                "Your architecture, {}, is truly fantastic. However, I don't currently support it.".format(  # noqa B950
+                "Your architecture, {}, is truly fantastic. However, I don't currently support it.".format(
                     arch
                 )
             )
@@ -213,7 +213,7 @@ def run(self, arguments, options):
 
         if not found:
             print(
-                "There doesn't seem to be an implementation of {} in the class hierarchy. Made a boo boo with the selector name?".format(  # noqa B950
+                "There doesn't seem to be an implementation of {} in the class hierarchy. Made a boo boo with the selector name?".format(
                     selector
                 )
             )
@@ -242,7 +242,7 @@ def run(self, arguments, options):
 
         if category:
             lldb.debugger.HandleCommand(
-                'breakpoint set --skip-prologue false --fullname "{}" --condition "{}"'.format(  # noqa B950
+                'breakpoint set --skip-prologue false --fullname "{}" --condition "{}"'.format(
                     breakpointFullName, breakpointCondition
                 )
             )
@@ -251,7 +251,7 @@ def run(self, arguments, options):
                 methodTypeCharacter, breakpointClassName, selector
             )
             lldb.debugger.HandleCommand(
-                'breakpoint set --skip-prologue false --func-regex "{}" --condition "{}"'.format(  # noqa B950
+                'breakpoint set --skip-prologue false --func-regex "{}" --condition "{}"'.format(
                     breakpointPattern, breakpointCondition
                 )
             )
@@ -279,7 +279,7 @@ def description(self):
 
     def run(self, arguments, options):
         fb.evaluateEffect(
-            "[[UIApplication sharedApplication] performSelector:@selector(_performMemoryWarning)]"  # noqa B950
+            "[[UIApplication sharedApplication] performSelector:@selector(_performMemoryWarning)]"
         )
 
 
@@ -432,7 +432,7 @@ def run(self, arguments, options):
 
         if len(arguments) == 0 or not arguments[0].strip():
             print(
-                "Usage: findinstances <classOrProtocol> [<predicate>]; Run `help findinstances`"  # noqa B950
+                "Usage: findinstances <classOrProtocol> [<predicate>]; Run `help findinstances`"
             )
             return
 

commands/FBDisplayCommands.py

@@ -47,7 +47,7 @@ def name(self):
         return "border"
 
     def description(self):
-        return "Draws a border around <viewOrLayer>. Color and width can be optionally provided. Additionally depth can be provided in order to recursively border subviews."  # noqa B950
+        return "Draws a border around <viewOrLayer>. Color and width can be optionally provided. Additionally depth can be provided in order to recursively border subviews."
 
     def args(self):
         return [
@@ -82,7 +82,7 @@ def options(self):
                 arg="depth",
                 type="int",
                 default=0,
-                help="Number of levels of subviews to border. Each level gets a different color beginning with the provided or default color",  # noqa B950
+                help="Number of levels of subviews to border. Each level gets a different color beginning with the provided or default color",
             ),
         ]
 
@@ -186,7 +186,7 @@ def name(self):
         return "mask"
 
     def description(self):
-        return "Add a transparent rectangle to the window to reveal a possibly obscured or hidden view or layer's bounds"  # noqa B950
+        return "Add a transparent rectangle to the window to reveal a possibly obscured or hidden view or layer's bounds"
 
     def args(self):
         return [
@@ -248,7 +248,7 @@ def name(self):
         return "caflush"
 
     def description(self):
-        return "Force Core Animation to flush. This will 'repaint' the UI but also may mess with ongoing animations."  # noqa B950
+        return "Force Core Animation to flush. This will 'repaint' the UI but also may mess with ongoing animations."
 
     def run(self, arguments, options):
         viewHelpers.flushCoreAnimationTransaction()

commands/FBFindCommands.py

@@ -23,7 +23,7 @@ def name(self):
         return "fvc"
 
     def description(self):
-        return "Find the view controllers whose class names match classNameRegex and puts the address of first on the clipboard."  # noqa B950
+        return "Find the view controllers whose class names match classNameRegex and puts the address of first on the clipboard."
 
     def options(self):
         return [
@@ -32,14 +32,14 @@ def options(self):
                 long="--name",
                 arg="classNameRegex",
                 type="string",
-                help="The view-controller-class regex to search the view controller hierarchy for.",  # noqa B950
+                help="The view-controller-class regex to search the view controller hierarchy for.",
             ),
             fb.FBCommandArgument(
                 short="-v",
                 long="--view",
                 arg="view",
                 type="UIView",
-                help="This function will print the View Controller that owns this view.",  # noqa B950
+                help="This function will print the View Controller that owns this view.",
             ),
         ]
 
@@ -93,7 +93,7 @@ def name(self):
         return "fv"
 
     def description(self):
-        return "Find the views whose class names match classNameRegex and puts the address of first on the clipboard."  # noqa B950
+        return "Find the views whose class names match classNameRegex and puts the address of first on the clipboard."
 
     def args(self):
         return [

commands/FBFlickerCommands.py

@@ -56,7 +56,7 @@ def args(self):
 
     def run(self, arguments, options):
         print(
-            "\nUse the following and (q) to quit.\n(w) move to superview\n(s) move to first subview\n(a) move to previous sibling\n(d) move to next sibling\n(p) print the hierarchy\n"  # noqa B950
+            "\nUse the following and (q) to quit.\n(w) move to superview\n(s) move to first subview\n(a) move to previous sibling\n(d) move to next sibling\n(p) print the hierarchy\n"
         )
 
         object = fb.evaluateInputExpression(arguments[0])

commands/FBInvocationCommands.py

@@ -20,7 +20,7 @@ def name(self):
         return "pinvocation"
 
     def description(self):
-        return "Print the stack frame, receiver, and arguments of the current invocation. It will fail to print all arguments if any arguments are variadic (varargs).\n\nNOTE: Sadly this is currently only implemented on x86."  # noqa B950
+        return "Print the stack frame, receiver, and arguments of the current invocation. It will fail to print all arguments if any arguments are variadic (varargs).\n\nNOTE: Sadly this is currently only implemented on x86."
 
     def options(self):
         return [
@@ -30,7 +30,7 @@ def options(self):
                 arg="all",
                 default=False,
                 boolean=True,
-                help="Specify to print the entire stack instead of just the current frame.",  # noqa B950
+                help="Specify to print the entire stack instead of just the current frame.",
             )
         ]
 
@@ -76,7 +76,7 @@ def printInvocationForFrame(frame):
         and str(signatureValue.GetError()) != "success"
     ):
         print(
-            "My sincerest apologies. I couldn't find a method signature for the selector."  # noqa B950
+            "My sincerest apologies. I couldn't find a method signature for the selector."
         )
         return