Restore fake timers after resetting mocks #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.53% (diff: 100%)@@ master #2467 diff @@
==========================================
Files 40 40
Lines 1653 1653
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1447 1447
Misses 206 206
Partials 0 0
|
Closed
|
@thymikee what's the status of this PR? |
thymikee
force-pushed
the
timers-with-resetMocks
branch
from
cf6917a to
9b644a8
Compare
|
It's finished, and should fix the problem with timers along with For this:
we now have |
Generated by 🚫 dangerJS |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fake timers are implemented as mocks. When defined in
package.jsonwith"timers": "fake"they set up mocking functions and work properly. However when combined with"resetMocks": truethey're not restored and completely gone.This is just a naive fix to the problem, but we can think of a better solution where we're actually in control of resetting mocks instead of wiping them out. Not sure how to approach it though.
PR includes integration test with these conflicting options.
Fixes #2455.
Test plan
Integration test