Skip to content

Commit 260e6d2

Browse files
Dmitry Zakharovfacebook-github-bot
Dmitry Zakharov
authored andcommitted
Remove shared bridge experiment
Reviewed By: kathryngray Differential Revision: D6284437 fbshipit-source-id: 14e0516f22dde04c0bbc4eb8fac603590d32d66a
1 parent e11d496 commit 260e6d2

File tree

2 files changed

+10
-39
lines changed

2 files changed

+10
-39
lines changed

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

+10-25
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,6 @@ public static ReactInstanceManagerBuilder builder() {
236236
@Nullable DevBundleDownloadListener devBundleDownloadListener,
237237
boolean useSeparateUIBackgroundThread,
238238
int minNumShakes,
239-
boolean splitPackagesEnabled,
240-
boolean useOnlyDefaultPackages,
241239
int minTimeLeftInFrameForNonBatchedOperationMs) {
242240
Log.d(ReactConstants.TAG, "ReactInstanceManager.ctor()");
243241
initializeSoLoaderIfNecessary(applicationContext);
@@ -273,30 +271,17 @@ public static ReactInstanceManagerBuilder builder() {
273271
mUseSeparateUIBackgroundThread = useSeparateUIBackgroundThread;
274272
mMinNumShakes = minNumShakes;
275273
synchronized (mPackages) {
276-
if (!splitPackagesEnabled) {
277-
CoreModulesPackage coreModulesPackage =
278-
new CoreModulesPackage(
279-
this,
280-
mBackBtnHandler,
281-
mUIImplementationProvider,
282-
mLazyViewManagersEnabled,
283-
mMinTimeLeftInFrameForNonBatchedOperationMs);
284-
mPackages.add(coreModulesPackage);
285-
} else {
286-
PrinterHolder.getPrinter().logMessage(ReactDebugOverlayTags.RN_CORE, "RNCore: Use Split Packages");
287-
mPackages.add(new BridgeCorePackage(this, mBackBtnHandler));
288-
if (mUseDeveloperSupport) {
289-
mPackages.add(new DebugCorePackage());
290-
}
291-
if (!useOnlyDefaultPackages) {
292-
mPackages.add(
293-
new ReactNativeCorePackage(
294-
this,
295-
mUIImplementationProvider,
296-
mLazyViewManagersEnabled,
297-
mMinTimeLeftInFrameForNonBatchedOperationMs));
298-
}
274+
PrinterHolder.getPrinter().logMessage(ReactDebugOverlayTags.RN_CORE, "RNCore: Use Split Packages");
275+
mPackages.add(new BridgeCorePackage(this, mBackBtnHandler));
276+
if (mUseDeveloperSupport) {
277+
mPackages.add(new DebugCorePackage());
299278
}
279+
mPackages.add(
280+
new ReactNativeCorePackage(
281+
this,
282+
mUIImplementationProvider,
283+
mLazyViewManagersEnabled,
284+
mMinTimeLeftInFrameForNonBatchedOperationMs));
300285
mPackages.addAll(packages);
301286
}
302287

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

-14
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ public class ReactInstanceManagerBuilder {
4848
private @Nullable JavaScriptExecutorFactory mJavaScriptExecutorFactory;
4949
private boolean mUseSeparateUIBackgroundThread;
5050
private int mMinNumShakes = 1;
51-
private boolean mEnableSplitPackage;
52-
private boolean mUseOnlyDefaultPackages;
5351
private int mMinTimeLeftInFrameForNonBatchedOperationMs = -1;
5452

5553
/* package protected */ ReactInstanceManagerBuilder() {
@@ -227,16 +225,6 @@ public ReactInstanceManagerBuilder setMinNumShakes(int minNumShakes) {
227225
return this;
228226
}
229227

230-
public ReactInstanceManagerBuilder setEnableSplitPackage(boolean enableSplitPackage) {
231-
mEnableSplitPackage = enableSplitPackage;
232-
return this;
233-
}
234-
235-
public ReactInstanceManagerBuilder setUseOnlyDefaultPackages(boolean useOnlyDefaultPackages) {
236-
mUseOnlyDefaultPackages = useOnlyDefaultPackages;
237-
return this;
238-
}
239-
240228
public ReactInstanceManagerBuilder setMinTimeLeftInFrameForNonBatchedOperationMs(
241229
int minTimeLeftInFrameForNonBatchedOperationMs) {
242230
mMinTimeLeftInFrameForNonBatchedOperationMs = minTimeLeftInFrameForNonBatchedOperationMs;
@@ -300,8 +288,6 @@ public ReactInstanceManager build() {
300288
mDevBundleDownloadListener,
301289
mUseSeparateUIBackgroundThread,
302290
mMinNumShakes,
303-
mEnableSplitPackage,
304-
mUseOnlyDefaultPackages,
305291
mMinTimeLeftInFrameForNonBatchedOperationMs);
306292
}
307293
}

0 commit comments

Comments
 (0)