Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage when setting borderWidth style prop #22488

Closed
2 of 3 tasks
FranDepascuali opened this issue Dec 3, 2018 · 3 comments
Closed
2 of 3 tasks

Memory usage when setting borderWidth style prop #22488

FranDepascuali opened this issue Dec 3, 2018 · 3 comments
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@FranDepascuali
Copy link

Environment

Run react-native info in your terminal and paste its contents here.

  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
      Memory: 109.26 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.9.0 - /usr/local/bin/node
      npm: 6.4.1 - /usr/local/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.4.2 => 16.4.2
      react-native: neiker/react-native#3ed7bc7bce0375effbc0d4b5e18842c3b3852e4c => 0.56.0
    npmGlobalPackages:
      eslint-plugin-react-native: 3.2.1
      react-native-cli: 2.0.1

Description

When using borderWidth prop in a view style, there is a spike in ram memory consumption. We have several components (~60) rendered with this prop. Thus crashes the app because of the suddenly high memory consumption.

Screencast

memory-leak-borderwidth

Screenshot

screen shot 2018-12-03 at 14 52 36

Reproducible Demo

This is a tricky one, try using a lot of views with borderWidth. #22221 related

@radeno
Copy link
Contributor

radeno commented Mar 14, 2019

@FranDepascuali is still an issue with latest RN 0.59?
If so then it should be classified as important.

@stale
Copy link

stale bot commented Aug 2, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 2, 2019
@stale
Copy link

stale bot commented Aug 9, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Aug 9, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants