Skip to content

Commit 537d1ca

Browse files
committed
Naming nits
- logRecoverableError -> reportError - queueRecoverableHydrationErrors -> upgradeHydrationErrorsToRecoverable
1 parent 98894be commit 537d1ca

13 files changed

+17
-18
lines changed

packages/react-art/src/ReactARTHostConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,6 @@ export function detachDeletedInstance(node: Instance): void {
452452
// noop
453453
}
454454

455-
export function logRecoverableError(error) {
455+
export function reportError(error) {
456456
// noop
457457
}

packages/react-dom/src/client/ReactDOMHostConfig.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,7 @@ export function getCurrentEventPriority(): * {
374374
return getEventPriority(currentEvent.type);
375375
}
376376

377-
/* global reportError */
378-
export const logRecoverableError =
377+
export const reportError =
379378
// $FlowFixMe Flow doesn't know about reportError
380379
typeof reportError === 'function'
381380
? // In modern browsers, reportError will dispatch an error event,

packages/react-native-renderer/src/ReactFabricHostConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,6 @@ export function detachDeletedInstance(node: Instance): void {
526526
// noop
527527
}
528528

529-
export function logRecoverableError(error: mixed): void {
529+
export function reportError(error: mixed): void {
530530
// noop
531531
}

packages/react-native-renderer/src/ReactNativeHostConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,6 @@ export function detachDeletedInstance(node: Instance): void {
514514
// noop
515515
}
516516

517-
export function logRecoverableError(error: mixed): void {
517+
export function reportError(error: mixed): void {
518518
// noop
519519
}

packages/react-noop-renderer/src/createReactNoop.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
467467

468468
detachDeletedInstance() {},
469469

470-
logRecoverableError() {
470+
reportError() {
471471
// no-op
472472
},
473473
};

packages/react-reconciler/src/ReactFiberCompleteWork.new.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ import {
131131
resetHydrationState,
132132
getIsHydrating,
133133
hasUnhydratedTailNodes,
134-
queueRecoverableHydrationErrors,
134+
upgradeHydrationErrorsToRecoverable,
135135
} from './ReactFiberHydrationContext.new';
136136
import {
137137
enableSuspenseCallback,
@@ -1105,7 +1105,7 @@ function completeWork(
11051105
// there may have been recoverable errors during first hydration
11061106
// attempt. If so, add them to a queue so we can log them in the
11071107
// commit phase.
1108-
queueRecoverableHydrationErrors();
1108+
upgradeHydrationErrorsToRecoverable();
11091109
}
11101110

11111111
if ((workInProgress.flags & DidCapture) !== NoFlags) {

packages/react-reconciler/src/ReactFiberCompleteWork.old.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ import {
131131
resetHydrationState,
132132
getIsHydrating,
133133
hasUnhydratedTailNodes,
134-
queueRecoverableHydrationErrors,
134+
upgradeHydrationErrorsToRecoverable,
135135
} from './ReactFiberHydrationContext.old';
136136
import {
137137
enableSuspenseCallback,
@@ -1105,7 +1105,7 @@ function completeWork(
11051105
// there may have been recoverable errors during first hydration
11061106
// attempt. If so, add them to a queue so we can log them in the
11071107
// commit phase.
1108-
queueRecoverableHydrationErrors();
1108+
upgradeHydrationErrorsToRecoverable();
11091109
}
11101110

11111111
if ((workInProgress.flags & DidCapture) !== NoFlags) {

packages/react-reconciler/src/ReactFiberHydrationContext.new.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ function resetHydrationState(): void {
607607
isHydrating = false;
608608
}
609609

610-
export function queueRecoverableHydrationErrors(): void {
610+
export function upgradeHydrationErrorsToRecoverable(): void {
611611
if (hydrationErrors !== null) {
612612
// Successfully completed a forced client render. The errors that occurred
613613
// during the hydration attempt are now recovered. We will log them in

packages/react-reconciler/src/ReactFiberHydrationContext.old.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ function resetHydrationState(): void {
607607
isHydrating = false;
608608
}
609609

610-
export function queueRecoverableHydrationErrors(): void {
610+
export function upgradeHydrationErrorsToRecoverable(): void {
611611
if (hydrationErrors !== null) {
612612
// Successfully completed a forced client render. The errors that occurred
613613
// during the hydration attempt are now recovered. We will log them in

packages/react-reconciler/src/ReactFiberWorkLoop.new.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ import {
7777
supportsMicrotasks,
7878
errorHydratingContainer,
7979
scheduleMicrotask,
80-
logRecoverableError,
80+
reportError,
8181
} from './ReactFiberHostConfig';
8282

8383
import {
@@ -2121,7 +2121,7 @@ function commitRootImpl(
21212121
} else {
21222122
// No user-provided onRecoverableError. Use the default behavior
21232123
// provided by the renderer's host config.
2124-
logRecoverableError(recoverableError);
2124+
reportError(recoverableError);
21252125
}
21262126
}
21272127
}

packages/react-reconciler/src/ReactFiberWorkLoop.old.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ import {
7777
supportsMicrotasks,
7878
errorHydratingContainer,
7979
scheduleMicrotask,
80-
logRecoverableError,
80+
reportError,
8181
} from './ReactFiberHostConfig';
8282

8383
import {
@@ -2121,7 +2121,7 @@ function commitRootImpl(
21212121
} else {
21222122
// No user-provided onRecoverableError. Use the default behavior
21232123
// provided by the renderer's host config.
2124-
logRecoverableError(recoverableError);
2124+
reportError(recoverableError);
21252125
}
21262126
}
21272127
}

packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export const prepareScopeUpdate = $$$hostConfig.preparePortalMount;
6868
export const getInstanceFromScope = $$$hostConfig.getInstanceFromScope;
6969
export const getCurrentEventPriority = $$$hostConfig.getCurrentEventPriority;
7070
export const detachDeletedInstance = $$$hostConfig.detachDeletedInstance;
71-
export const logRecoverableError = $$$hostConfig.logRecoverableError;
71+
export const reportError = $$$hostConfig.reportError;
7272

7373
// -------------------
7474
// Microtasks

packages/react-test-renderer/src/ReactTestHostConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,6 @@ export function detachDeletedInstance(node: Instance): void {
315315
// noop
316316
}
317317

318-
export function logRecoverableError(error: mixed): void {
318+
export function reportError(error: mixed): void {
319319
// noop
320320
}

0 commit comments

Comments
 (0)