Skip to content

Commit 5660c52

Browse files
author
Brian Vaughn
authored
Scheduling Profiler: Improve warnings and add unit tests (#22038)
* Scheduling Profiler: Updated instructions to mentioned v18+ requirement * Moved long-event warning to post processing This lets us rule out non-React work or React work that started before the event and finished quickly during the event. Also added unit tests for this warning and the various cases. * Moved long-event warning to post processing This lets us rule out non-React work or React work that started before the event and finished quickly during the event. Also added unit tests for this warning and the various cases. * Updated nested update warning text * Udpate warning about suspending outside of a transition Handle edge case where component suspends before the first commit (and label metadata) has been logged. Add unit tests. * Fixed logic error in getBatchRange() with minStartTime * PR feedback: Combined a conditional statement
1 parent b9934d6 commit 5660c52

File tree

5 files changed

+977
-443
lines changed

5 files changed

+977
-443
lines changed

packages/react-devtools-scheduling-profiler/src/SchedulingProfiler.css

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
.WelcomeInstructionsListItemLink {
5555
color: var(--color-link);
5656
margin-left: 0.25rem;
57+
margin-right: 0.25rem;
5758
}
5859

5960
.ImportButtonLabel {

packages/react-devtools-scheduling-profiler/src/SchedulingProfiler.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const Welcome = ({onFileSelect}: {|onFileSelect: (file: File) => void|}) => (
8686
target="_blank">
8787
profiling build of ReactDOM
8888
</a>
89-
.
89+
(version 18 or newer).
9090
</li>
9191
<li className={styles.WelcomeInstructionsListItem}>
9292
Open the "Performance" tab in Chrome and record some performance data.

0 commit comments

Comments
 (0)