Skip to content

Commit a110dc2

Browse files
author
Brian Vaughn
committed
Remove unnecessary ReactMutableSource fork
1 parent 6abeb5b commit a110dc2

File tree

7 files changed

+10
-54
lines changed

7 files changed

+10
-54
lines changed

packages/react-dom/src/client/ReactDOMRoot.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ export type RootOptions = {
2929
...
3030
};
3131

32-
import {findHostInstanceWithNoPortals} from 'react-reconciler/src/ReactFiberReconciler';
33-
import {registerMutableSourceForHydration} from 'react-reconciler/src/ReactMutableSource';
3432
import {
3533
isContainerMarkedAsRoot,
3634
markContainerAsRoot,
@@ -48,6 +46,8 @@ import {ensureListeningTo} from './ReactDOMComponent';
4846
import {
4947
createContainer,
5048
updateContainer,
49+
findHostInstanceWithNoPortals,
50+
registerMutableSourceForHydration,
5151
} from 'react-reconciler/src/ReactFiberReconciler';
5252
import invariant from 'shared/invariant';
5353
import {

packages/react-reconciler/src/ReactFiberReconciler.js

+6
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ import {
4949
findBoundingRects as findBoundingRects_old,
5050
focusWithin as focusWithin_old,
5151
observeVisibleRects as observeVisibleRects_old,
52+
registerMutableSourceForHydration as registerMutableSourceForHydration_old,
5253
} from './ReactFiberReconciler.old';
5354

5455
import {
@@ -86,6 +87,7 @@ import {
8687
findBoundingRects as findBoundingRects_new,
8788
focusWithin as focusWithin_new,
8889
observeVisibleRects as observeVisibleRects_new,
90+
registerMutableSourceForHydration as registerMutableSourceForHydration_new,
8991
} from './ReactFiberReconciler.new';
9092

9193
export const createContainer = enableNewReconciler
@@ -186,3 +188,7 @@ export const focusWithin = enableNewReconciler
186188
export const observeVisibleRects = enableNewReconciler
187189
? observeVisibleRects_new
188190
: observeVisibleRects_old;
191+
192+
export const registerMutableSourceForHydration = enableNewReconciler
193+
? registerMutableSourceForHydration_new
194+
: registerMutableSourceForHydration_old;

packages/react-reconciler/src/ReactFiberReconciler.new.js

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ import {
8787
findHostInstancesForRefresh,
8888
} from './ReactFiberHotReloading.new';
8989

90+
export {registerMutableSourceForHydration} from './ReactMutableSource.new';
9091
export {createPortal} from './ReactPortal';
9192
export {
9293
createComponentSelector,

packages/react-reconciler/src/ReactFiberReconciler.old.js

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ import {
8585
findHostInstancesForRefresh,
8686
} from './ReactFiberHotReloading.old';
8787

88+
export {registerMutableSourceForHydration} from './ReactMutableSource.old';
8889
export {createPortal} from './ReactPortal';
8990
export {
9091
createComponentSelector,

packages/react-reconciler/src/ReactMutableSource.js

-24
This file was deleted.

scripts/jest/setupHostConfigs.js

-8
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@ jest.mock('react-reconciler/src/ReactFiberReconciler', () => {
1010
);
1111
});
1212

13-
jest.mock('react-reconciler/src/ReactMutableSource', () => {
14-
return require.requireActual(
15-
__VARIANT__
16-
? 'react-reconciler/src/ReactMutableSource.new'
17-
: 'react-reconciler/src/ReactMutableSource.old'
18-
);
19-
});
20-
2113
// When testing the custom renderer code path through `react-reconciler`,
2214
// turn the export into a function, and use the argument as host config.
2315
const shimHostConfigPath = 'react-reconciler/src/ReactFiberHostConfig';

scripts/rollup/forks.js

-20
Original file line numberDiff line numberDiff line change
@@ -280,26 +280,6 @@ const forks = Object.freeze({
280280
return 'react-reconciler/src/ReactFiberReconciler.old.js';
281281
},
282282

283-
'react-reconciler/src/ReactMutableSource': (
284-
bundleType,
285-
entry,
286-
dependencies,
287-
moduleType,
288-
bundle
289-
) => {
290-
if (bundle.enableNewReconciler) {
291-
switch (bundleType) {
292-
case FB_WWW_DEV:
293-
case FB_WWW_PROD:
294-
case FB_WWW_PROFILING:
295-
// Use the forked version of the reconciler
296-
return 'react-reconciler/src/ReactMutableSource.new.js';
297-
}
298-
}
299-
// Otherwise, use the non-forked version.
300-
return 'react-reconciler/src/ReactMutableSource.old.js';
301-
},
302-
303283
'react-reconciler/src/ReactFiberHotReloading': (
304284
bundleType,
305285
entry,

0 commit comments

Comments
 (0)