Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is possible to render & replace nodes #1311

Closed
zpao opened this issue Mar 27, 2014 · 3 comments
Closed

Make is possible to render & replace nodes #1311

zpao opened this issue Mar 27, 2014 · 3 comments

Comments

@zpao
Copy link
Member

zpao commented Mar 27, 2014

This has come up a bunch, it might be time to just do it.

@nathansobo
Copy link

I'm experimenting with using React to render our editor views in Atom. We're trying to make Atom as agnostic as possible when it comes to view frameworks, and I'm shooting for a simple standard in which views assume that other views expose an .element property which is the top-level DOM element for that view.

I could be missing important details here, but it would be great to be able to create a detached component instance and just request its root element, then attach that element wherever. Then a React component would look pretty much like any other view from the perspective of the rest of the system. It would just be an object with an .element property.

@sophiebits
Copy link
Collaborator

Might make sense to wait to do this until after @sebmarkbage's inverted-control stuff.

@sophiebits
Copy link
Collaborator

Closing in favor of #1711 which solves this problem and actually has a concrete API proposal attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants