Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useMutableSource: Release version snapshots once hydration is finished #18835

Closed
bvaughn opened this issue May 5, 2020 · 0 comments
Closed

useMutableSource: Release version snapshots once hydration is finished #18835

bvaughn opened this issue May 5, 2020 · 0 comments
Assignees
@bvaughn
Labels
React Core Team Opened by a member of the React Core Team

Comments

@bvaughn
Copy link
Contributor

bvaughn commented May 5, 2020

Follow up for #18183 and PR #18771.

Decide when to clear mutableSourceEagerHydrationData. We don't currently have a way to detect when all outstanding hydration work is finished. (It may never finish.) This means that in use cases where the version is the entire sore (e.g. an immutable store without a version "number") we would retain a reference to that store, preventing it from being GCed.
@bvaughn bvaughn added the React Core Team Opened by a member of the React Core Team label May 5, 2020
@bvaughn bvaughn self-assigned this May 5, 2020
@bvaughn bvaughn mentioned this issue May 5, 2020
Merged
3 tasks
@bvaughn bvaughn changed the title Bug: useMutableSource: Release version snapshots once hydration is finished May 5, 2020
@gaearon gaearon closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvaughn @gaearon